Problem/Motivation
The Bitbucket integration using an app password is currently not working because the password is never saved. The reason is that the form uses an incorrect method to check if the password is empty or not (FormStateInterface::get()
instead of FormStateInterface::getValue()
).
Steps to reproduce
* Create a Bitbucket build hook environment
* Generate a bitbucket app password
* Go to Configuration -> Build Hooks -> Bitbucket Build Hooks Settings
* Enter your username and the app password
* Go to the build hook environment
* The page displayes a 401 Unauthorized error from the Bitbucket API.
Proposed resolution
Patch will follow that uses the correct method.
Comment | File | Size | Author |
---|---|---|---|
#2 | bitbucket_app_password_not_saved-3212632-2.patch | 751 bytes | klaasvw |
Comments
Comment #2
klaasvw CreditAttribution: klaasvw at Randstad Digital commentedPatch attached to fix the issue.
Comment #3
klaasvw CreditAttribution: klaasvw at Randstad Digital commentedComment #5
larowlanNormally I'd require a test for this but I don't use bitbucket so don't want to hold things up
This will go out as 3.1.2
Comment #6
larowlanhttps://www.drupal.org/project/build_hooks/releases/3.1.2