Problem/Motivation

There is a new Drupal core security release.
One of the patches on varbase_core prevents the upgrade

Drupal 8.9.19 was released 15 Sep 2021 at 18:56 EEST
https://www.drupal.org/project/drupal/releases/8.9.19

Problem/Motivation

Remove the patch from #2996114: Argument 2 passed to Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}() must be an instance of Drupal\jsonapi\ResourceType\ResourceType, NULL given

Temp Quick fix to update Drupal core

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Remove the 2996114-99.patch and not to use the 2996114-124.patch or any back ported
  • ✅ Testing to ensure no regression
  • ❌ Automated unit/functional testing coverage
  • ❌ Developer Documentation support on feature change/addition
  • ❌ User Guide Documentation support on feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • Quick Fix Release for varbase_core-8.8.37

User interface changes

  • None

API changes

  • None

Data model changes

  • None
CommentFileSizeAuthor
#2 fix.3233156-2.patch954 bytesjedgar1mx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jedgar1mx created an issue. See original summary.

jedgar1mx’s picture

FileSize
954 bytes
Rajab Natshah’s picture

Issue summary: View changes

Thank you, Edgar for reporting and patching

Rajab Natshah’s picture

Title: Patch breaking latest drupal upgrade » Update Drupal core from 8.9.18 to 8.9.19 ( ~8.0 ) and remove applied patches
Issue summary: View changes
Rajab Natshah’s picture

Title: Update Drupal core from 8.9.18 to 8.9.19 ( ~8.0 ) and remove applied patches » Update Drupal core from 8.9.18 to 8.9.19 ( ~8.0 ) and change not applying patches
Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 13b4d51 on 8.x-8.x authored by jedgar1mx
    Issue #3233156 by jedgar1mx, RajabNatshah: Update Drupal core from 8.9....
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Assigned: Unassigned » Mohammed J. Razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-8.8.12, +varbase_core-8.8.35
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Issue summary: View changes

  • RajabNatshah committed f77a237 on 8.x-8.x
    Issue #3233156 by jedgar1mx, RajabNatshah: Update Drupal core from 8.9....
Rajab Natshah’s picture

Issue summary: View changes
Issue tags: +varbase_core-8.8.36
Rajab Natshah’s picture

Issue summary: View changes
jedgar1mx’s picture

I'm still getting issues but this time is due to patch #124. I had to remove the patch completely for now. I think it was merged in to 8.x-dev and was release with the latest version of drupal. Here is the code for anyone having issues.

"patches-ignore": {
            "drupal/varbase_core": {
              "drupal/core": {
                "Issue #2996114: Fix Argument 2 passed to Drupal jsonapi Routing closure must be an instance of ResourceType, NULL given":
        "https://www.drupal.org/files/issues/2020-02-11/2996114-124.patch"
              }
            }
}
Rajab Natshah’s picture

You are right Edgar.
It's not working now
I had 2 new builds and installs + 1 update process with the 124 patch
But now it's not patching!

Chaining back to remove the patch

Rajab Natshah’s picture

Version: 8.x-8.34 » 8.x-8.x-dev
Assigned: Unassigned » Rajab Natshah
Status: Fixed » Active
Rajab Natshah’s picture

Title: Update Drupal core from 8.9.18 to 8.9.19 ( ~8.0 ) and change not applying patches » Update Drupal core from 8.9.18 to 8.9.19 ( ~8.0 ) and remove committed patches
Issue summary: View changes

Rajab Natshah’s picture

Assigned: Rajab Natshah » Mohammed J. Razem
Status: Active » Needs review
Issue tags: +varbase_core-8.8.37
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Status: Fixed » Closed (fixed)