Problem/Motivation

Coding standard and Mess detector is highlighting some issues with this module.

Afaiks there are 78 errors count on phpcs and 1 on phpmd

CommentFileSizeAuthor
#6 3236749_phpcs.png56.06 KBhmendes

Issue fork log_stdout-3236749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bladedu created an issue. See original summary.

Bladedu opened merge request !2

Bladedu’s picture

Bladedu
he/him
Primary language Italian
Location Italy
CreditAttribution: Bladedu at SparkFabrik commented
Status: Active » Needs review

I've dropped the function getUserName() because it's never used. For the time being we're just logging the user ID.

We could open a separate issue to provide support for a new token (let's say @username) in both settings form and default formatting if you think it's a valuable information to have in logs.

hmendes made their first commit to this issue’s fork.

Bladedu’s picture

Bladedu
he/him
Primary language Italian
Location Italy
CreditAttribution: Bladedu at SparkFabrik commented

Thank you @hmendes for the contribution.

If you don't see anything else I'd say we can merge it.

hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
3236749_phpcs.png56.06 KB

Hi @Bladedu, the only "problem" that my phpcs shows is on README.md, so I think is everything fine to merge.

  • Bladedu committed 4cee1a0 on 8.x-1.x 
    Issue #3236749 by Bladedu, hmendes: Fix coding standards
Bladedu’s picture

Bladedu
he/him
Primary language Italian
Location Italy
CreditAttribution: Bladedu at SparkFabrik commented

great! I normally exclude *.md files from phpcs.

Thank you a lot for your feedbacks!

Bladedu’s picture

Bladedu
he/him
Primary language Italian
Location Italy
CreditAttribution: Bladedu at SparkFabrik commented
Status: Reviewed & tested by the community » Fixed
Bladedu’s picture

Bladedu
he/him
Primary language Italian
Location Italy
CreditAttribution: Bladedu at SparkFabrik commented
Status: Fixed » Closed (fixed)