Problem/Motivation

#3278625: Deprecate/remove jquery.tabbable.shim is blocked on removing some core usages and has missed the 9.4.0 release.

Since the library itself isn't deprecated in 9.x yet, we'll need to deprecate it in 10.1.x for removal in 11.0.0.

The shim itself issues a deprecation message, this should be updated for removal in 11.0.0 to reflect reality.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3296096-drupal10.patch2.82 KBGábor Hojtsy
#7 3296096-7.patch2.83 KBGábor Hojtsy
#7 interdiff.txt1.31 KBGábor Hojtsy
#4 3296096-4.patch1.52 KBsmustgrave
#4 interdiff-2-4.txt298 bytessmustgrave
#2 3296096.patch1.64 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Active » Needs review
FileSize
3296096.patch1.64 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Parent issue: » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
FileSize
interdiff-2-4.txt298 bytes
3296096-4.patch1.52 KB

Rerolled it so it should apply

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

need to fix errors,

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Needs review

Sent for a retest, I don't think the non-pass of the test is related to the patch.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
FileSize
interdiff.txt1.31 KB
3296096-7.patch2.83 KB

Should look at the actual result, duh. Tests were not yet updated. Updating now.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Needs work

Looks like we need a separate 10.x patch.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Needs review
FileSize
3296096-drupal10.patch2.82 KB

There you go.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The shim itself issues a deprecation message, this should be updated for removal in 11.0.0 to reflect reality.

All 4 appearances of the deprecation message are addressed.

RTBC for me, if TestBot doesn't smite me down with failed tests.

  • catch committed ebfd359 on 10.0.x 
    Issue #3296096 by Gábor Hojtsy, smustgrave, catch, Spokje: Update...
  • catch committed 69d084f on 10.1.x
    Issue #3296096 by Gábor Hojtsy, smustgrave, catch, Spokje: Update...
  • catch committed 1600b7a on 9.5.x
    Issue #3296096 by Gábor Hojtsy, smustgrave, catch, Spokje: Update...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.