Problem/Motivation

From #3281449-3: Update Core unit tests to not use Bartik and Seven:

+++ b/core/tests/Drupal/Tests/Core/Extension/ExtensionDiscoveryTest.php
@@ -130,13 +130,6 @@ protected function populateFilesystemStructure(array &$filesystem_structure) {
-      'core/themes/seven/seven.info.yml' => [
-        'type' => 'theme',
-      ],
-      // Override the core instance of the 'seven' theme.
-      'sites/default/themes/seven/seven.info.yml' => [
-        'type' => 'theme',
-      ],

This test doesn't seem to be testing what it thinks it is testing, as removing this, or breaking it in a couple of different ways, didn't cause the test to fail. This probably needs investigation and a better fix elsewhere.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3298319

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

immaculatexavier made their first commit to this issue’s fork.

nod_’s picture

catch’s picture

OK this line was added in #2605654: Modify Drupal\Core\Extension\ExtensionDiscovery to allow for scanning multiple file systems, enabling vfsStream testing, it's not testing anything specific as such, just extra coverage added by that patch, which means there's no specific regression we can compare against either. I think we can just either changes this to claro or just 'test_theme' ought to work here since it's entirely simulated anyway.

nod_’s picture

Status: Active » Needs review
FileSize
938 bytes

went with test_theme

nod_’s picture

Status: Needs review » Reviewed & tested by the community

self rtbc because green and trivial.

  • catch committed 88e3e39 on 10.1.x
    Issue #3298319 by nod_: Update ExtensionDiscoveryTest to not use seven
    
catch’s picture

Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

  • catch committed ba84fab on 10.0.x
    Issue #3298319 by nod_: Update ExtensionDiscoveryTest to not use seven...
  • catch committed eaa7f2e on 9.5.x
    Issue #3298319 by nod_: Update ExtensionDiscoveryTest to not use seven...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.