Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
From #3281449-3: Update Core unit tests to not use Bartik and Seven:
+++ b/core/tests/Drupal/Tests/Core/Extension/ExtensionDiscoveryTest.php @@ -130,13 +130,6 @@ protected function populateFilesystemStructure(array &$filesystem_structure) { - 'core/themes/seven/seven.info.yml' => [ - 'type' => 'theme', - ], - // Override the core instance of the 'seven' theme. - 'sites/default/themes/seven/seven.info.yml' => [ - 'type' => 'theme', - ],
This test doesn't seem to be testing what it thinks it is testing, as removing this, or breaking it in a couple of different ways, didn't cause the test to fail. This probably needs investigation and a better fix elsewhere.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#5 | core-3298319-5.patch | 938 bytes | nod_ |
|
Issue fork drupal-3298319
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nod_Comment #4
catchOK this line was added in #2605654: Modify Drupal\Core\Extension\ExtensionDiscovery to allow for scanning multiple file systems, enabling vfsStream testing, it's not testing anything specific as such, just extra coverage added by that patch, which means there's no specific regression we can compare against either. I think we can just either changes this to claro or just 'test_theme' ought to work here since it's entirely simulated anyway.
Comment #5
nod_went with
test_theme
Comment #6
nod_self rtbc because green and trivial.
Comment #8
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!