See commit f80735ee347128ffd77a7077dc13b67153751fee

We lost it somewhere.

CommentFileSizeAuthor
#14 bring-back-delta-rendering-3191628-14.patch1002 bytesrwam
#12 Screen Shot 2021-05-20 at 5.41.38 PM.png51.62 KBsrdtwc
#12 Screen Shot 2021-05-20 at 5.41.28 PM.png21.14 KBsrdtwc
#6 3191628-6.patch12.96 KBswentel
#4 3191628-4.patch12.2 KBswentel
#2 3191628-2.patch11.14 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel created an issue. See original summary.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Active » Needs review
FileSize
3191628-2.patch11.14 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3191628-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs work » Needs review
FileSize
3191628-4.patch12.2 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3191628-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs work » Needs review
FileSize
3191628-6.patch12.96 KB

  • swentel committed 29a77e8 on 8.x-3.x 
    Issue #3191628 by swentel: Bring back 'delta' rendering
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs review » Fixed

Committed, no release yet because I want to get #3025928: TranslationLanguageRenderer not using row style configurations in too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Version: 8.x-3.x-dev » 8.x-4.x-dev
Status: Closed (fixed) » Active

Needs to go into 8.x-4.x as well

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

Remember to not break it again for older PHP versions, see #3203249: Syntax error on PHP <7.3

srdtwc’s picture

srdtwc CreditAttribution: srdtwc commented
FileSize
Screen Shot 2021-05-20 at 5.41.28 PM.png21.14 KB
Screen Shot 2021-05-20 at 5.41.38 PM.png51.62 KB

I believe that this change is causing an issue where empty "field__item" elements are created for each item, even when the UI limit is set to exclude them. These items do not contain the actual content, but are just an empty wrapper.

screenshot of config

screenshot of config

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

@srdtwc Hmm that seems weird, might be related with something else.
Is everything fine in case you revert the patch?

rwam’s picture

rwam CreditAttribution: rwam commented
FileSize
bring-back-delta-rendering-3191628-14.patch1002 bytes

Hi @swentel,

I had the same issue as described in #12. Besides of reverting the patch I've created a quick fix. The following patch solves this weird issue of rendering empty field items which broke our preview view mode in the backend (using core/themes/seven/templates/classy/field/field.html.twig for rendering).

Ciao
Ralf

  • swentel committed 5d9012c on 8.x-3.x authored by rwam 
    Issue #3191628 by rwam: Bring back 'delta' rendering
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

So yes, I switched from unset to #access FALSE because that's 'cleaner' in a way, but indeed, the field item wrappers are still printed.
Using unset again is fine for me, so committed, thanks!

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Version: 8.x-4.x-dev » 8.x-3.x-dev
Status: Active » Fixed
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Fixed » Closed (fixed)