FILE: \modules\ds\src\Form\ClassesForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
30 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\src\Form\EmergencyForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\src\Plugin\Derivative\DsEntityRow.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\src\Plugin\DsLayout.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
80 | WARNING | #description values usually have to run through t() for translation
171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
179 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------

FILE: \modules\ds\src\Plugin\views\row\EntityRow.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
161 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\BlockFieldPluginTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
204 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\BlockTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
89 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\CacheTagsTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\DsFieldCacheTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\EntitiesTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
88 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
147 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
148 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
212 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
230 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\ExportablesTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
64 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
65 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\FieldGroupTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\FieldPluginTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\FieldTemplateTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\HiddenRegionTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\LayoutClassesTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 18 WARNINGS AFFECTING 18 LINES
------------------------------------------------------------------------------------------------------------------------------------------
51 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
86 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
88 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
89 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\LayoutFluidTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
26 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
27 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\LayoutPluginTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
28 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\TwigRenderTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: \modules\ds\tests\src\Functional\ViewsTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------------------------------------
73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
100 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
116 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
118 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#23 3117905-23.patch18.12 KBswentel
#19 3117905-19.patch20.64 KBSuresh Prabhu Parkala
#18 error-after-apply-patch-ds-3117905.png224.87 KBDharti Patel
#16 3117905-16.patch31.62 KBneelam_wadhwani
#14 3117905-14.patch54.98 KBneelam_wadhwani
#12 interdiff_9-12.txt28.49 KBneelam_wadhwani
#12 3117905-12.patch54.53 KBneelam_wadhwani
#9 3117905-9.patch31.26 KBneelam_wadhwani
#8 3117905-8.patch30.91 KBneelam_wadhwani
#7 3117905-7.patch25.59 KBneelam_wadhwani
#6 3117905-6.patch25.86 KBneelam_wadhwani
#5 3117905-5.patch25.89 KBneelam_wadhwani
#4 3117905-4.patch25.72 KBneelam_wadhwani
#3 3117905-3.patch25.2 KBneelam_wadhwani
#2 3117905-2.patch25.2 KBneelam_wadhwani
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neelam_wadhwani created an issue. See original summary.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-2.patch25.2 KB

Kindly review patch.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-3.patch25.2 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-4.patch25.72 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-5.patch25.89 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-6.patch25.86 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-7.patch25.59 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-8.patch30.91 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-9.patch31.26 KB
neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

Some files contain "tabs".
+ <TAB> use StringTranslationTrait;

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Status: Needs work » Needs review
FileSize
3117905-12.patch54.53 KB
interdiff_9-12.txt28.49 KB

I have solved coding standard.
Kindly review patch.

Status: Needs review » Needs work

The last submitted patch, 12: 3117905-12.patch, failed testing. View results

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Status: Needs work » Needs review
FileSize
3117905-14.patch54.98 KB
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

This also contains fixes from #3121109: Some minor bugs and coding standard - becomes a bit confusing to read.

(also, some coding standard fixes are weird, but oh well)

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3117905-16.patch31.62 KB

I have updated patch.

Dharti Patel’s picture

Dharti Patel CreditAttribution: Dharti Patel as a volunteer and at QED42 commented
Assigned: Unassigned » Dharti Patel
Dharti Patel’s picture

Dharti Patel CreditAttribution: Dharti Patel as a volunteer and at QED42 commented
Assigned: Dharti Patel » Unassigned
Status: Needs review » Needs work
FileSize
error-after-apply-patch-ds-3117905.png224.87 KB

Hello @neelam_wadhwani,
I've review the #16 patch but after applying the patch facing the below issue.

Please find attached a screenshot for the error. Need to move in Need to work.

Thanks!

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3117905-19.patch20.64 KB

Here is the updated patch. Please review.

Status: Needs review » Needs work

The last submitted patch, 19: 3117905-19.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language English
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

1- Failed test case related to field_group 

Drupal\Tests\ds\Functional\FieldGroupTest::testFieldPlugin
Error: Class 'Drupal\Tests\field_group\Functional\Drupal' not found

Can be fixed using the patch here: https://www.drupal.org/project/field_group/issues/330808

2- Warning: array_flip(): Can only flip STRING and INTEGER values!
Here is related issue: https://www.drupal.org/project/drupal/issues/3249389

NOTE: Both the test case failure are not related to this module.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Version: 8.x-4.x-dev » 5.0.x-dev

moving to new branch, wait until branch tests work before working on this again

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs work » Needs review
FileSize
3117905-23.patch18.12 KB

rerolled against 5.0.x

  • swentel committed ca4cd8f on 5.0.x 
    Issue #3117905 by neelam_wadhwani, swentel, Suresh Prabhu Parkala,...
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs review » Fixed

committed and pushed, thanks.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Fixed » Closed (fixed)
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Version: 5.0.x-dev » 8.x-3.x-dev
Status: Closed (fixed) » Active

  • swentel committed 4c6a148b on 8.x-3.x 
    Issue #3117905 by neelam_wadhwani, swentel, Suresh Prabhu Parkala,...
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas commented
Status: Active » Fixed
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas commented
Status: Fixed » Closed (fixed)