I have an email action configured to send an email to the author of a node. I wanted to trigger that action when changing from one state to another but the email was not properly set. By looking at the code of the email action (system.module), I noticed that it expects the $node object directly as the $object argument of the do_action() function, when the action type is 'system'.

Attach is a patch that fixes this.

- Drupal 6.8 / PHP Version 5.2.6-0.1~lenny1 / Debian 5.0 (testing)

CommentFileSizeAuthor
workflow.module.patch721 byteshanoii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tnanek’s picture

tnanek CreditAttribution: tnanek commented

Works well for me, thanks!

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

And for me...! Well-spotted hanoii!
Much appreciated.

cYu’s picture

cYu CreditAttribution: cYu commented
Status: Needs review » Needs work

This had the unwanted side effect of breaking token replacement on e-mail actions of type system when applied to my install. E-mail body went from...

Node created at localhost:8888/mysite/node/16421
to
Node created at localhost:8888/mysite/node/[nid]

after I applied this patch.

westbywest’s picture

westbywest CreditAttribution: westbywest commented

subscribing

seanburlington’s picture

seanburlington CreditAttribution: seanburlington commented

Works for me

Thanks :-)

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Needs work » Needs review

Works for me. I set up a clean install of drupal 6.13 + workflow 6.x-1.1 + this patch + token 6.x-1.x-dev and was unable to reproduce the problem in #3. Is anyone still having problems with this patch?

Jen

ranj.sarraj’s picture

ranj.sarraj CreditAttribution: ranj.sarraj commented

Love the patch, work like a charm

really appreciate, all the best Haonii

anawillem’s picture

anawillem CreditAttribution: anawillem commented

awesome. worked for me. wonder why this hasn't been fixed in the newest version? are other folks having the same issue? in any case, it fixed it for me. thanks for this - so much.

anawillem’s picture

anawillem CreditAttribution: anawillem commented

Still not fixed in the newest release of workflows module (oct 23rd?) for 6.x (I just implemented it on monday, and it broke this again). Is anyone paying attention to this post?

taoliu’s picture

taoliu CreditAttribution: taoliu commented

Thanks a lot! It worked great and fixed my problem that some token variables in emails were not replaced. I am using the newest release of workflow and have not encountered any issue mentioned above.

vitis’s picture

vitis CreditAttribution: vitis commented

sub

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented
Status: Needs review » Closed (duplicate)

http://drupal.org/node/253711