Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The "Show label colon" in the field settings on my "Manage display" tab has no effect at all if I choose the default field template. As I'm using the basic theme (https://www.drupal.org/project/basic) the colon never shows up, no matter if checked or not. In the Bartik theme the colon always shows up, even if unchecked.
Am I missing something? In the other field templates (expert, minimal) it seems to work correctly.
Comment | File | Size | Author |
---|---|---|---|
#4 | 3007357-4.patch | 626 bytes | swentel |
Comments
Comment #2
DanielVezaWe had similar issues with the bootstrap theme. We fixed it like this
custom_theme.theme file
Add this line to field.html.twig. A line similar to this may already exist and you may need to modify it.
<div{{ title_attributes.addClass(title_classes) }}>{{ label }}{% if settings['lb-col'] %}:{% endif -%}</div>
If these instructions are too vague, give me a bell and I'll see if we can fix the problem outside of this issue queue.
I'm unsure if this is an issue that should be fixed at the DS level or the theme level.
Comment #3
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #4
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedYeah, there's isn't much we can do there. patch adds a warning that this setting might not have any effect at all.
Comment #6
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #7
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #8
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedHi swentel,
Following up on your comment on #3208931-4: TestBot returns with "Build Successful" when there are too many test failures to report #4 and #6 I did a quick comparison of the logs on the D9 and D10 test runs. It seems that if you have no nightwatch.js tests, on D9 runs this was marked as a warning, but in D10 it gives an error.
To avoid this, you can modify the project's drupalci.yml file and in the assessment: testing: section delete the nightwatchjs: line. If you do not have a drupalci.yml file you can get the default from https://git.drupalcode.org/project/project_issue_file_test/blob/HEAD/job...
More info can be found on https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes...
Hope this helps.
Comment #9
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedInteresting, I wonder if this is the core issue which caused it: #3306446: Update Nightwatch to 2.4.1
Comment #10
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedThanks for the link. I am sure that's the cause, so I have added my comment to that issue.
Comment #11
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #12
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedHi swentel, was that an accidental update in #10 above? Or did you mean to re-open and revert the version from 5.0.x to 8.x-3.x?
Comment #14
swentel CreditAttribution: swentel at eps & kaas commentedThat was very much on purpose to commit this on 8.x-3.x as well.
Comment #15
swentel CreditAttribution: swentel at eps & kaas commentedComment #16
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedOh, yes I see. Sorry for the noise.