Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The ID attribute would be very useful to build SPAs or just to link to a specific section of the page.
Proposed resolution
Add the ID attribute to the settings of all the rocketship layouts.
Remaining tasks
- Patch
- Review
- Test
User interface changes
The configuration forms of the rocketship sections now have the option to set the id attribute
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | rocketship_core-3319398-2.patch | 2.33 KB | akalam |
Comments
Comment #2
akalam CreditAttribution: akalam at Dropsolid commentedI'm adding the id attribute here as a patch instead of a MR because the Drupal infra is experimenting delays and the fork is not available yet. Moving to "Needs review".
Comment #3
nginex CreditAttribution: nginex as a volunteer and at Dropsolid for Dropsolid commentedComment #5
nginex CreditAttribution: nginex as a volunteer and at Dropsolid for Dropsolid commentedThanks for the patch. I adjusted a bit code to avoid empty id attribute.
Comment #6
akalam CreditAttribution: akalam at Dropsolid commentedThanks to you for reviewing and for the fixes.