Problem/Motivation

In #3261266: Remove deprecated code from the testing framework (base classes, listeners, etc), we kept a layer to control that WebAssert methods do not get called with a wrong number of parameters, waiting for PHPStan for a better solution.

Now the solution is there: PHPStan level 1 rule; and we can get rid of that layer.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3322961

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !2997

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie at Dropsolid commented
Status: Needs review » Reviewed & tested by the community

Looking at the MR this seems a nice cleanup. And indeed since we now have phpstan on level 1, no new items could be introduced here, which is what the old code tried to prevent us from.

  • longwave committed d2e813e on 10.0.x 
    Issue #3322961 by mondrake: Fix WebAssert since PHPStan can now check...
  • longwave committed 5c1863a on 10.1.x
    Issue #3322961 by mondrake: Fix WebAssert since PHPStan can now check...
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5c1863a060 to 10.1.x and d2e813ee08 to 10.0.x. Thanks!

mondrake closed merge request !2997

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Very nice! 🤩

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.