Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In UserViewsData there is a useless line of help text that could be removed.
Steps to reproduce
View UserViewsData.php
See 2 lines of help text
Proposed resolution
Removed useless line of help text.
Remaining tasks
Review
Commit
User interface changes
NA
API changes
NA
Data model changes
NA
Release notes snippet
NA
Original post
core/modules/user/src/UserViewsData.php:85 ambiguous text
title or help?
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff_2-5.txt | 832 bytes | ravi.shankar |
#5 | 3265724-5.patch | 831 bytes | ravi.shankar |
| |||
#4 | Screenshot 2022-05-15 at 21.18.57.png | 67.62 KB | alexpott |
#4 | Screenshot 2022-05-15 at 21.19.49.png | 58.48 KB | alexpott |
#2 | 3265724.patch | 940 bytes | nevergone |
|
Comments
Comment #2
nevergone CreditAttribution: nevergone as a volunteer commentedComment #3
Aron NovakLGTM
Comment #4
alexpottI think that we should remove
$data['users_field_data']['langcode']['help'] = $this->t('Original language of the user information');
the current title is better.Before
After
Comment #5
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedMade changes as per comment #4.
Comment #6
smustgrave CreditAttribution: smustgrave at Mobomo commentedSeems like an easy fix but would like an issue summary next time please.
Comment #7
quietone CreditAttribution: quietone at PreviousNext commentedSorry to push back on a simple change but this needs a title change. The title is part of the commit message and should reflect the change. The title here has nothing to do with the actual change, which is now removing a line of useless code. Will someone update the title?
And yes, I agree to an Issue Summary, even on a small issue the proposed resolution should be clear to reviewers and committers.
Comment #8
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #9
longwaveIssue title and patch look good to me now.
Comment #10
alexpottCommitted and pushed 254b587f31 to 10.1.x and ce69564e16 to 10.0.x and b12569bc9f to 9.5.x and 2db48c5175 to 9.4.x. Thanks!