When I was writing the xmlsitemap_engines.module in 6.x-2.x, I took a look at the current 6.x-1.x module and I frankly think it is way too complex for it's own good.
1. Why are users allowed to change the submission URLs of search engines? If users want custom submission URLs, give them a textarea to put them in.
2. The verification code/interface is jumbling things up and frankly is not *required* in order to submit the sitemap to search engines. In the case of Google Webmaster Tools, you only need to verify ownership to see advanced crawling statistics.
As I've done in the 6.x-2.x engines module, I propose cutting this stuff out. I have already started a general search engine Site verification module. So it can be re-used by people and when they have verified their sites with all the desired search engines, they can simply disable the module.
To show how simple I think this module's interface should be, I have attached a screenshot of the current 6.x-2.x engines interface (ignore the security warning and the development teaser). Compare that to the current 6.x-1.x interface. Yes, I still need to implement the 'submit every x' setting, but you can see the difference in simplicity between the two.
Comment | File | Size | Author |
---|---|---|---|
#4 | 464980-xmlsitemap-engines-D6-1.patch | 7.13 KB | Dave Reid |
XML Sitemap | localhost_1242536405226.png | 50.75 KB | Dave Reid |
Comments
Comment #1
apadernoThe purpose of allowing the user to change the submission URLs is to allow them to update it when the search engines would change it.
That is code that has been developed before I became co-maintainer, and I left it there. Actually, I think that the possibility that the search engines would change the submission URL is remote, and that part can be probably removed.
About the verification data fields, I agree that they can be removed, if the user get the right informations about what to do, and which module install. Until the module you are talking of does not have an official release, I would prefer to keep those form fields.
Take in mind that maybe the search engines will ask more than once for the verification file (at least that happened to me more than once, without adding a new sitemap), and maybe the user will keep the module installed.
Comment #2
Dave ReidI just created the first official release of site_verify.
In response to #1, I'd say that if search engines change their URLs, we can always make sure we update the module. Easy as that. :) Yeah, and users can decide when they want to disable/remove the search engine verification module.
Comment #3
apadernoThe module is well done, and it has more options that XML sitemap could not offer, like the possibility to upload the verification file.
The only thing I can report is that the module is too generic in the settings page; the page for the settings for Google shows the same options, and default values shown for any other modules. As I reported in #467582: Change the settings page, you could remove that list of predefined search engines, and let the user add to the list any search engine he wants.
If the module shows the same form fields for any search engine, to say that it supports Google Webmaster Tools, Google Apps, Live Search Webmaster Central, and Yahoo! Site Explorer is not exact; it would support any search engine without the need to add new code. The only code to change in the module should be the part that shows a static list of 4 entries, and remove the limitation of 4 search engines.
Comment #4
Dave ReidHere's the patch to remove all the verification code from xmlsitemap_engines for review.
Comment #5
Dave ReidKiam, you did see that the site_verify has the 'custom' engine to add verifications for any other engines right? And that the custom engine can be added over and over again?
Comment #6
apadernoI saw that; still that static four entries are not required.
Just to make an example of what the Drupal core code does, does path.module have a static list of four or more path aliases that still need to be enabled from the administrator user?
Comment #7
apadernoAs I already explained, this task is postponed.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedI've disabled the user being able to modify the search engine ping using [#disabled] = TRUE for 1.0. Should I bother with the verification code removal; seeing that 2.x is looming close?
Comment #10
Dave ReidI think it's worth removing since we already have Site verification module.
Comment #11
Dave ReidI would suggest removing all the verification stuff from hook_menu() and the interface, but don't delete the variables (but still delete them on uninstall however). I'm writing an "import" path in site_verify to import any of the variables if xmlsitemap_engines.module hasn't been uninstalled:
I'd also add this update to xmlsitemap_engines.module:
Comment #12
Dave ReidSearch engine verification settings have been removed in 6.x-1.x CVS (http://drupal.org/cvs?commit=259918). Upgrade path is provided:
Comment #14
AlexisWilke CreditAttribution: AlexisWilke commentedDave,
Could you put a link on the home page of this module to the Secure Verification module?
That way, silly people like me can find the module really quick! 8-)
Thank you.
Alexis
Comment #15
Anonymous (not verified) CreditAttribution: Anonymous commented@AlexisWilke: Good suggestion but please open a new issue.