On /admin/content/node --
Check the 'Select all' checkbox in the non-floating header, the floating header remains unchecked.
Check the 'Select all' checkbox in the floating header, uncheck it in the non-floating header, the floating header remains checked.
Check the 'Select all' checkbox in either header, uncheck any other checkbox, the non-floating header is unchecked (correctly), the floating header remains checked.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LAsan’s picture

Version: 6.x-dev » 7.x-dev

Confirmed. Same happens in 7.x-dev.

redndahead’s picture

Status: Active » Needs review
FileSize
819 bytes

Here is a patch to include the cloned header on update. One thing that this patch will miss is when the select all box is checked on page load. The issue is the cloned table header is loaded after the update of the select all box on the initial load. Not sure when this will come up.

EDIT: Nevermind on the initial load the js will clone the checked state also.

drewish’s picture

i wonder if it's related but i'd noticed that the header isn't fully cloned when it start floating. if you set a class on the fixed header once it starts floating the formatting is lost until it stops floating.

Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

Status: Needs work » Needs review
FileSize
815 bytes

Now improved with a reroll and 4 less bytes. Get it now while it's hot.

Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

Status: Needs work » Needs review

Hmm don't see how this patch could make the file naming test fail. Maybe bad result? Moving back to review

cburschka’s picture

I have submitted the patch for re-testing.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

Status: Needs work » Needs review
catch’s picture

Status: Needs review » Needs work

I can't see the select all checkbox in the floating table header at all (ff3/ubuntu) - with or without the patch.

casey’s picture

Status: Needs work » Needs review
FileSize
919 bytes

Even smaller patch.

I do see the select-all checkbox (FF3/XP).

casey’s picture

Still applies. anyone?

casey’s picture

#14: tableselect-tableheader.patch queued for re-testing.

nod_’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community
FileSize
803 bytes
783 bytes

just a reroll, don't credit me.

Works fine, 'nuf said :)

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7
Albert Volkman’s picture

Status: Patch (to be ported) » Needs review
FileSize
783 bytes

Reuploading nod_'s D7 patch from #17 for testbot.

nod_’s picture

Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/efd12ac

Moving to 6.x for possible backport.

Albert Volkman’s picture

Status: Patch (to be ported) » Needs review
FileSize
780 bytes

D6 backport.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.