Update blogapi module to use drupal_static() [#480122]

Comment	File	Size	Author
#4	jamesan_480122-4.patch	665 bytes	JamesAn

#3	jamesan_480122-3.patch	664 bytes	JamesAn

#1	jamesan_480122-2.patch	657 bytes	JamesAn

Comment #1

JamesAn CreditAttribution: JamesAn commented 2 June 2009 at 21:05

Title:	Update blog module to use drupal_static()	» Update blogapi module to use drupal_static()
Component:	blog.module	» blogapi.module
Status:	Active	» Needs review

File	Size
jamesan_480122-2.patch	657 bytes

The blog module doesn't use static vars. The blogapi module uses 1 static var, $xmlrpcusererr, in blogapi_error(). I'm not sure what this static var does, but it's never reset.

Log in or register to post comments

Comment #2

cburschka

they

CreditAttribution: cburschka commented 2 June 2009 at 23:50

Adding a comment to that effect seems just superfluous, though. Change it or don't change it...

Wait, isn't the drupal_static intended to allow a clearing of *all* statics, even those that functions don't intend to reset, during tests?

Log in or register to post comments

Comment #3

JamesAn CreditAttribution: JamesAn commented 3 June 2009 at 02:08

File	Size
jamesan_480122-3.patch	664 bytes

Makes sense. I was probably running on automatic.. =P There were a small handful of static vars, mostly in the testing code, that remained static. But yes, the majority of static vars should be converted over as was intended.

Log in or register to post comments

Comment #4

JamesAn CreditAttribution: JamesAn commented 3 June 2009 at 03:32

File	Size
jamesan_480122-4.patch	665 bytes

Log in or register to post comments

Comment #5

catch

he/him

English

CreditAttribution: catch commented 7 June 2009 at 02:16

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

Comment #6

Dries CreditAttribution: Dries commented 7 June 2009 at 02:23

deimos:drupal-cvs dries$ grep -r xmlrpcusererr .
./modules/blogapi/blogapi.module:  static $xmlrpcusererr;
./modules/blogapi/blogapi.module:  return xmlrpc_error($xmlrpcusererr + 1, strip_tags($message));

The variable is never set ... That code doesn't make sense to me.

Log in or register to post comments

Comment #7

JamesAn CreditAttribution: JamesAn commented 7 June 2009 at 03:44

Well, the patch turns the first result into:
modules/blogapi/blogapi.module: $xmlrpcusererr = &drupal_static(__FUNCTION__);

The second line has been with Drupal since at least 4.6, according to api.drupal.org. You're right. It seems $xmlrpcusererr is never set. Still, I'm not familiar with the XML-RPC protocol.

Maybe someone who knows more about the BlogAPI can shed some light?