The imagecache_create_url() function calls url() setting $query to FALSE rather than to NULL, this is causing url() to add a trailing '?' in URLs when $bypass_browser_cache = FALSE (default).

Attached patch corrects this.

Note: patch taken from imagecache.module file, since I did this change in SVN of one of my projects in a rush.

CommentFileSizeAuthor
#4 imagecache_461104.D6.patch871 bytesdrewish
#4 imagecache_461104.D5.patch866 bytesdrewish
imacache_querystring.patch689 bytesrecidive
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

riccardoR’s picture

riccardoR CreditAttribution: riccardoR commented

I can confirm that the patch works as described.
I did the same change before finding this issue.

recidive’s picture

recidive CreditAttribution: recidive commented
Status: Needs review » Reviewed & tested by the community

@riccardoR: thanks.

Setting this to RTBC.

recidive’s picture

recidive CreditAttribution: recidive commented

Can we get this one liner commited?

drewish’s picture

drewish CreditAttribution: drewish commented
Version: 5.x-2.4 » 6.x-2.x-dev
Priority: Normal » Minor
FileSize
imagecache_461104.D5.patch866 bytes
imagecache_461104.D6.patch871 bytes

realized it was a problem in 6 as well and just back ported the patch i'd rolled for that to 5.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Reviewed & tested by the community » Fixed

committed to HEAD and DRUPAL-5--2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.