Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The imagecache_create_url() function calls url() setting $query to FALSE rather than to NULL, this is causing url() to add a trailing '?' in URLs when $bypass_browser_cache = FALSE (default).
Attached patch corrects this.
Note: patch taken from imagecache.module file, since I did this change in SVN of one of my projects in a rush.
Comment | File | Size | Author |
---|---|---|---|
#4 | imagecache_461104.D6.patch | 871 bytes | drewish |
#4 | imagecache_461104.D5.patch | 866 bytes | drewish |
imacache_querystring.patch | 689 bytes | recidive |
Comments
Comment #1
riccardoR CreditAttribution: riccardoR commentedI can confirm that the patch works as described.
I did the same change before finding this issue.
Comment #2
recidive CreditAttribution: recidive commented@riccardoR: thanks.
Setting this to RTBC.
Comment #3
recidive CreditAttribution: recidive commentedCan we get this one liner commited?
Comment #4
drewish CreditAttribution: drewish commentedrealized it was a problem in 6 as well and just back ported the patch i'd rolled for that to 5.
Comment #5
drewish CreditAttribution: drewish commentedcommitted to HEAD and DRUPAL-5--2