The original pager implementation was scrapped from the Seven theme issue (#484860: Initial D7UX admin theme) because it requires another core patch applied, namely #514914: Re-add removed feature of $limit "passing" for themers, and that dependency was uncomfortable for that issue as far as I've understood. Now, we should fix this issue, since the current pager looks less informative, so here is a follow up with the pager.
Pager looks in Seven before this patch:
After this patch:
Still requires #514914: Re-add removed feature of $limit "passing" for themers which should be committed first or this patch is totally broken.
Comment | File | Size | Author |
---|---|---|---|
#21 | 538788_pager_with_select_nav.png | 7.02 KB | Sivaji_Ganesh_Jojodae |
#21 | 538788_seven_pager_21.patch | 5.64 KB | Sivaji_Ganesh_Jojodae |
#19 | 538788_reroll.png | 2.54 KB | Sivaji_Ganesh_Jojodae |
#19 | 538788_pager_last.png | 3.54 KB | Sivaji_Ganesh_Jojodae |
#19 | 538788_pager_intermediate.png | 4.05 KB | Sivaji_Ganesh_Jojodae |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedWorks for me. Not sure if there's supposed to be any discussion over this new pager's functionality, but if this is the design then why not go for it? Sorry, still a Drupal issue tracker newb, but is it ok to RTBC like this?
Comment #2
rszrama CreditAttribution: rszrama commentedI may have spoke too soon. I noticed a pager saying "1 - 0 of 19" on the taxonomy page when I was adding terms to a vocabulary. Without this patch, the normal pager isn't displayed at all. See image:
Comment #3
Gábor HojtsyInteresting, since the issue being committed at #514914: Re-add removed feature of $limit "passing" for themers should have made this work. Hum. Are you sure you work with an up to date Drupal 7 checkout?
Comment #4
Gábor HojtsyI've reapplied this patch to my testing environment and it still works as advertised above. Now that it does not have any dependencies. It would be great to verify this independently, but I still see this working. In the watchdog reports table:
Patch rerolled because it had some fuzz applying.
Comment #6
rszrama CreditAttribution: rszrama commentedI'll try it again after I restore my D7 dev site... something broke it last night. : P
fwiw, I had just checked out D7 yesterday from HEAD when I saw that problem on a taxonomy term list page.
Comment #7
Gábor HojtsyHere is a fresh reroll of the patch. Tested again, and it still works for me. Anyone else to verify?
Comment #8
yoroy CreditAttribution: yoroy commentedHavent' looked at it in IE, but FF and Safari looking dandy.
Comment #9
mr.baileysTested in IE 7 (some other items on the page are screwy, but both before and after patch), FF 3.5 and Safari 3 and the pager looks (and works) great, definitely an improvement. I was unable to reproduce the problem described in #2 and the pager worked consistently and had the correct numbers.
My only concern so far is
I've always been told that floats should have an explicit width (although it seems the sentence "a floated box must have an explicit width" has recently been removed from the CSS2.1 specs). What is the reasoning behind using
float:right
instead oftext-align:right
? Not sure the positioning of the element following the pager is ideal when using floats (see screenshot).Comment #10
yoroy CreditAttribution: yoroy commentedchanged the float to a text-align
Comment #11
mattyoung CreditAttribution: mattyoung commented.
Comment #12
xmacinfoIf we want to use this new pager, which looks nice we need to make it
- easier to jump forward and backward,
- to jump to a specific page and also
- to tell the exact number of remaining items instead of showing the paging value.
We must keep First and Last. Example:
«First ‹Previous 50 Showing 100 – 150 of 250 Next 50› Last»
In this example, the 100 in bold should be clickable to show a simple form field, aka edit in place where the user would type a number to jump to the record.
Paging through a long list can be easy or painful. Let's not make this patch painful. :-)
Also, in this example:
«First ‹Previous 50 Showing 100 – 150 of 156 Next 6› Last»
... the Next part should be intelligent enough to display 6 (156 - 150). Using the 50 items on a page value is wrong here. Make it intelligent.
Comment #14
mattyoung CreditAttribution: mattyoung commented@xmacinfo:
>the 100 in bold should be clickable to show a simple form field, aka edit in place where the user would type a number to jump to the record
You mean like this: Jump pager?
Comment #15
xmacinfo@mattyoung:
Yes. This Minimax page module expose the current page number in a field for easy jump. But if we want a nice styling and look à la Seven, we could hide the field and expose it only when clicking on the current page number.
For example, clicking on the current page (or range):
«First ‹Previous 50 Showing 100 – 150 of 156 Next 6› Last»
would become
«First ‹Previous 50 [ 100 ] of 156 Next 6› Last»
where [ 100 ] would be the exposed field that would serve as jump. And in this example value permitted would be from 1 to 156 since we know that the max known is 156.
Comment #16
rickvug CreditAttribution: rickvug commented#10: pagers.patch queued for re-testing.
Comment #17
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented+1 for this pager it looks much better. The above patch fails to display link to first and last page which is required for easy navigation and it no longer works because the
theme_pager_link()
function signature has been changed as a part of #572618: All theme functions should take a single argument to make preprocess sane and meaningful. Attached patch adds link to first and last page and changes to match signature.Comment #18
xmacinfoPlease provide a screen capture.
Also, please add a jump box in the middle of the pager. Without a jump box, this sort pager, although more beautiful, is not usable. See my comment in #15.
Comment #19
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedI have attached screenshots with this comment, will re-roll a patch with jump box similar to 538788_reroll.png.
BTW : How do i add screenshot inline like #7 ?
Comment #20
xmacinfoLooks nice! Adding the jump box will make it ready to rock.
A small note, in the intermediate version of the screen capture, the
... showing 51 - 100 of 207 ...
uses a range (51 to 100), which is fine in itselft. However, when combined with a jumpbox, it becomes tricky, since we might not want to ask the user to input the value of both start and end range. We should instead ask only for the start of the range:
... showing [50] - 100 of 207 ...
What do you think?
Comment #21
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedAttached patch provides a way for quick navigation as mentioned in #18.
@xmacinfo, I am using list select instead of inputbox see the attached snapshot and patch. I know the patch needs work, i like to confirm that i am on right track here.
Comment #23
xmacinfoIndeed, select is the way to go for ranges. Much more clean. But I would include the whole range in the select input items:
« First « Prev 50 [400 - 450] of 1001 Next 50 » Last »
[400 - 450] => the displayed range in an item in the select list...
I cannot review the rest of your patch or the TO DO! for new. :-)
Comment #24
Bojhan CreditAttribution: Bojhan commentedI am going to push this feature to Drupal 8. Looking at the progress so far and considering that we are deep into UI freeze.
This feature has no clear usability win, although Mark Boulton did indeed design it this way and we are striving to implent it as such, there is no sign that we are actually improving anything. Sure with the latest patch I can navigate to page 77, but who knows whats on page 77?
Our current pager, although not the best looking one out there - has no known usability flaws, nor is its inability to jump to be found a huge problem.
Comment #25
Jeff Burnz CreditAttribution: Jeff Burnz commentedsub
Comment #26
droplet CreditAttribution: droplet commented@Bojhan,
users know what's on Page 77.
eg. I filtered a list of articles and navigate to page 77. I would know my content is on page 77 now. when i go to other computer or next time to edit the article I will jump to page 77 directly.
Comment #27
Gaelan CreditAttribution: Gaelan commented#21: 538788_seven_pager_21.patch queued for re-testing.
Comment #29
JohnAlbinMarking #1488866: Redesign pagers for administrative lists. as a dupe.
An improved pager would make things easier for mobile users as well, as long as the touch targets were large enough.
Comment #30
mondrakeHi all, you may want to take a look at the Pagerer module I recently contributed. http://drupal.org/project/pagerer
Comment #31
mgiffordThis is going to have to change when Views comes into D8 Core, right? Otherwise it's just a matter of getting someone to look at migrating the patch from #21 to the new /core structure.
@Bojhan, I'm assuming that this is both a usability improvement as well as just a matter of following the original design, right?
How do we get this moving so that Seven looks better than it did in D7?
Comment #32
LewisNyman CreditAttribution: LewisNyman commentedI'm going to consider this an duplicate of #2016867: Pager Style Update. If anyone has any objections to the pager design found in the new Seven style guide we can take it up there.
Comment #33
xmacinfoThe issue at #2016867: Pager Style Update is a complete regression that does not take into account any discussion taken here. Please do not sidetrack.
Comment #34
LewisNyman CreditAttribution: LewisNyman commentedOk, but I do think it's counter productive to have the two discussions completely separate. We can't commit both.
Comment #35
LewisNyman CreditAttribution: LewisNyman commentedOk, we've managed to figure out a good separation between issues. See my comment here:
https://drupal.org/node/2016867#comment-7572783
Keep up the good work!
Comment #36
Bojhan CreditAttribution: Bojhan commentedSo what is this issue still about?
Comment #37
Bojhan CreditAttribution: Bojhan commentedDiscussed this with Lewis
This is really a new feature and it would be nice, but not really needed for release.
Comment #41
Gábor HojtsyComment #53
quietone CreditAttribution: quietone at PreviousNext commentedI asked for help in #frontend to move Seven and Classy issues from the core component to the correct place, since Seven and Classy have been removed from core. markconroy responded saying this issue should move to the Seven project in contrib. They were not able to do that because the meta data was not visible (don't know why). So, I am moving this issue. markconroy already has credit on the Seven triage meta issue so there is no need to add credit. #3332483: [Meta] Seven issue triage