Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Patch adds a setting to browscap to allow user to determine how often browscap should check garykeith.com for new data. User can set the interval to any number of days, 7 days is still the default. Setting the number of days to 0 turns off updating.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | add-configurable-update-interval-545384-10.patch | 4.63 KB | Devin Carlson |
| #8 | add-configurable-update-interval-545384-8.patch | 4.44 KB | Devin Carlson |
| #4 | 545384_browscap_interval.patch | 2.78 KB | greggles |
| browscap-interval.patch | 2.72 KB | timhill |
Comments
Comment #1
jcruz CreditAttribution: jcruz commentedsubscribe
Comment #2
gregglesCan you explain the motivation for this? It feels like useless UI cruft to me, but I've just started using the module.
Comment #3
timhill CreditAttribution: timhill commentedIt's a little crufty, I'll admit. My main motivation with the patch was to add the ability to turn off auto-updating. This is useful for situations where a server cannot "phone out" and for users who would like more direct control and would prefer to update the browscap file manually. I decided to make the patch able to set the update interval just in case someone still wanted auto-update but didn't want to "phone out" so often.
Comment #4
gregglesI wanted to test this and had to re-roll it. I also tweaked the spacing on the multiplication. It seems good to me - can you confirm that it still works for you? If so then we could commit it.
Comment #5
timhill CreditAttribution: timhill commentedSorry for the delay, the patch looks good, works in version 1.1
Comment #6
klonosIt would be nice to have this in the official and dev builds.
Comment #7
greggles@klonos - rather than stating a preference, it would be useful if you could review the patch.
Comment #8
Devin Carlson CreditAttribution: Devin Carlson commentedMoving to 7.x and backporting.
The attached patch adds a configurable update interval as in #4 but includes a small number of improvements including improved spelling, more specific error messages and bring back the return of
system_settings_form.Comment #9
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted to 7.x-1.x.
Comment #10
Devin Carlson CreditAttribution: Devin Carlson commentedBackport of #8.
Comment #11
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted to 6.x-1.x.