Perhaps I'm wrong but for me taxonomy filter should apply to nodes last revision. In current drupal version (6.2) filter is built using term_node.nid matching with node.nid and it should be term_node.vid with node.vid :
line 194 should look like :
$join .= "INNER JOIN {term_node} $table ON n.vid = $table.vid ";
Comment | File | Size | Author |
---|---|---|---|
#26 | show_last_version_of_node-262498-26.patch | 540 bytes | Thomas_Zahreddin |
#9 | 262498-remove-taxonomy-content-filter.patch | 697 bytes | DjebbZ |
#4 | node.admin_.inc_.patch | 483 bytes | EugenMayer |
Comments
Comment #1
nonsieStill present in 6.12
Comment #2
Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commentedno patch, but still exists.
Comment #3
EugenMayer CreditAttribution: EugenMayer commentedbump up, still present in 6.14
Comment #4
EugenMayer CreditAttribution: EugenMayer commentedPatch attached. Killes found / fixed it
Comment #5
Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commentedLet's get that into 6.15
Comment #6
Gábor HojtsyBugs are first fixed on Drupal 7 and then backported to Drupal 6 to ensure we do not introduce regressions.
Comment #7
xjmComment #8
EugenMayer CreditAttribution: EugenMayer commentedi would schedule this complicated fix and review for around the year 2015, or even slighly later. This is also a little to bloody-edge for 8.x
Comment #9
DjebbZ CreditAttribution: DjebbZ commentedIn D8, one can't filter nodes tagged with a certain tag. The menu callback function for the page
admin/content
does not propose a way to filter nodes by term. The only filters proposed bynode_filters()
are the status, the node type and optionally the language. The function is the same in D7. But in D6 we can filter by terms (seen in code and in the UI). What do we do for D8 ? Do we allow the possibility to filter by term ? Or do we remove the legacy code ?Here's a patch for the second option (the most easy one), even if I would prefer the first option. I don't know why it was removed.
Comment #10
DjebbZ CreditAttribution: DjebbZ commentedForgot to change status.
Comment #11
agentrickardVery odd. The patch addresses cruft that was left in after an existing feature was removed.
My opinion is that we should commit the patch and then work on fixing the issue by providing better content admin tools in core.
Comment #12
DjebbZ CreditAttribution: DjebbZ commentedI want to agree with you here. What about D7 and D6 ? I would say backport the patch to D7 (should be easy).
Comment #13
dawehnerAnd for d6 the patch from eugenmayer should be used, as it's a bug there.
Comment #14
agentrickardD7, yes. But D6 is supposed to allow taxonomy filtering.
Comment #15
dawehnerWe can't write a patch which tests a non existing feature, or?
The code which removes it looks fine!
Comment #16
xjm#15: Yeah, I agree there's no test to write here.
Comment #17
Dries CreditAttribution: Dries commentedCommitted to 8.x. Moving to 7.x.
Comment #18
dawehnerLet's see what the testbot thinks, if it works fine, it's RTBC.
Comment #19
xjm#9: 262498-remove-taxonomy-content-filter.patch queued for re-testing.
Comment #21
xjmSo #9 is RTBC for D7.
Comment #22
webchickCommitted and pushed to 7.x too.
Marking this issue fixed, though it sounds like we need a follow-up to replace this functionality in D8.
Comment #23
EugenMayer CreditAttribution: EugenMayer commentedwell, isnt that fixed when its also applied to D6?
Comment #24
xjmNeeds a current D6 port. :)
Comment #25
xjmdurr
Comment #26
Thomas_Zahreddin CreditAttribution: Thomas_Zahreddin commentedtried with #0 but as patch ;-) for D 6.x (dev)
(and meanwhile some people agree it's better to speak of versions if you mean versions).
Comment #27
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedYep, that looks good and fixes the issue for me.
Comment #28
Kristen PolI applied patch #26 successfully as well.
Comment #29
star-szrFixed in 6.x via #648516: content/admin/node pager_query with taxonomy filter returns incorrect results when multiple versions of nodes are kept.