Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As discussed in #567564: Disable the taxonomy/term display by default we shouldn't use the menu_alter to redirect merged terms, because this breaks other modules like Taxonomy Breadcrumb and Panels3.
By default, the redirect is now disabled and it's working with other modules, but there might be better ways to implement this.
So I started an issue where we can work on a patch
Comment | File | Size | Author |
---|---|---|---|
#9 | path_redirect.patch | 3.02 KB | yan |
#8 | taxonomy_manager.admin_.inc_.rej_.txt | 1.95 KB | yan |
#7 | taxonomy_manager.admin_.inc_.patch | 2.95 KB | dicreat |
#5 | taxonomy_manager-n569086-2.patch | 2.91 KB | DamienMcKenna |
#2 | taxonomy_manager-n569086.patch | 2.91 KB | DamienMcKenna |
Comments
Comment #1
DamienMcKennaSubscribing. I suggest using Path_Redirect if available.
Comment #2
DamienMcKennaInitial patch that..
Comment #3
DamienMcKennaComment #4
dankohn CreditAttribution: dankohn commentedThat patch has an error in it. You need to change module_enabled('path_redirect') to module_exists('path_redirect')
With that change, the patch appears to do the right thing and is a welcome improvement.
Given that I also confirmed the incompatibility with Panels 3, I would suggest removing the existing redirect functionality entirely, and have the module just do a path_redirect by default instead (but still allow the checkbox to be unchecked). That would make path_redirect a prerequisite for this module, which would be fine.
Comment #5
DamienMcKennaGah. I forgot to update the module with my local test code. Here's a corrected patch.
Comment #6
digi24 CreditAttribution: digi24 commentedThanks for the patch Damien. Maybe it would be useful to add a default option or omit the whole options thing. After all, it is the expected behaviour, when using the redirect module:
Comment #7
dicreat CreditAttribution: dicreat commentedThanks for the patch Damien and digi24.
I just make little fix - now patch works with new Path redirect module version 6.x-1.0-beta6. Please review.
Be careful, new version of Path redirect work only with Pathauto 6.x-1.x-dev.
Comment #8
yan CreditAttribution: yan commentedPatch failed against 6.x-2.x-dev:
Comment #9
yan CreditAttribution: yan commentedAdapted the patch to latest -dev, works fine for me.
Please review.
Comment #10
yan CreditAttribution: yan commentedPatch from #9 works fine for me, just one "whitespace error":
Comment #11
kardave CreditAttribution: kardave commentedApplied the last patch against the 6.x-2.2 with no errors or warning. Redirection now works fine!
Thank you very much!
Comment #12
yan CreditAttribution: yan commentedTried it again against dev and it works just fine. Patch output is this:
Can this be committed?
Comment #13
yan CreditAttribution: yan commentedConfirming again that this works. RTBC
Comment #14
ivnish CreditAttribution: ivnish commented