Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Module does not have any entry in permission table, I think should be at least one entry for allow view report (admin/reports/browscap), just because there is no way to delegate this option to other roles.
Comment | File | Size | Author |
---|---|---|---|
#11 | add-permissions-650688-11.patch | 2.39 KB | Devin Carlson |
#8 | add-permissions-650688-8.patch | 2.47 KB | Devin Carlson |
#6 | browscap_650588_6_hook_perm.patch | 2.8 KB | Simon Georges |
#2 | browscap_650588_2_hook_perm.patch | 2.8 KB | Simon Georges |
Comments
Comment #1
klonosI agree, I need this one too.
...subscribing
Comment #2
Simon Georges CreditAttribution: Simon Georges commentedPatch provided.
Comment #3
gregglesLooks mostly OK to me. However, given that the configuring can change an important function I suggest "administer browscap" instead of just "configure browscap."
What do you think?
Comment #4
Simon Georges CreditAttribution: Simon Georges commentedFine for me ;) Do you want me to re-roll a patch ?
Comment #5
gregglesPlease do, yes.
Comment #6
Simon Georges CreditAttribution: Simon Georges commentedNew patch, with "administer browscap", done on the latest 6.x-1.x-dev.
Comment #7
klonos#6 seems to work fine. Thanx ;)
Comment #8
Devin Carlson CreditAttribution: Devin Carlson commentedMoving to Browscap 7.x and then backporting.
The attached patch adds the permissions outlined in #6 to Browscap 7.x.
Comment #9
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted to 7.x-1.x.
Moving back to 6.x and marking as "needs work" to test the last patch for 6.x and ensure that it uses the same permission names as the 7.x patch.
Comment #10
Devin Carlson CreditAttribution: Devin Carlson commentedComment #11
Devin Carlson CreditAttribution: Devin Carlson commentedBackport of #8.
Comment #12
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted to 6.x-1.x.
Comment #13
klonosThanx Devin! One less patch to keep around and having to re-apply with each installation.
PS: ...welcome as a new co-maintainer of Browscap btw ;)