As you know support custom jquery ui dialog options, there is a bug if buttons are added to the modalframe.
The autoresize method is nor properly calculating the size, as it does skip the button pane.

I have attached a patch which does correct that ( patched against 6.x-1.6) . It does not affect "none buttons" dialogs.

Thanks

CommentFileSizeAuthor
parent.js_buttonpane.patch1.12 KBEugenMayer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented
Status: Needs review » Closed (duplicate)

- #595800: Making it possible to show buttons

EugenMayer’s picture

EugenMayer CreditAttribution: EugenMayer commented
Status: Closed (duplicate) » Needs review

does that mean you wont include that patch?

EugenMayer’s picture

EugenMayer CreditAttribution: EugenMayer commented

i mean that other issue was about adding custom options what you denied and later implemented (like the hiding of the loading icon..but who cares).

That one actually fixes a bug that you can know pass buttons, but you cant show them due the resize bug.

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented
Status: Needs review » Closed (duplicate)

You can redefine the Drupal.modalFrame.resize() method in a separete script loaded by another module if you want this feature. Cheers

[EDIT] I do not plan to add support for jQuery UI Dialog buttons for the reasons described in the other issue.