Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Examples:
- Token
- FileField
- ImageField
- CCK
And backports from Drupal 7
- Vertical Tabs
- Admin
Comment | File | Size | Author |
---|---|---|---|
#58 | upgrade_status-HEAD.d7.58.patch | 4.84 KB | sun |
#42 | upgrade_status-HEAD.d7.42.patch | 13.88 KB | sun |
#41 | upgrade_status-HEAD.d7.41.patch | 13.88 KB | sun |
#33 | upgrade_status-620714-2.patch | 27.75 KB | philbar |
#31 | upgrade_status-620714-1.patch | 27.75 KB | philbar |
Comments
Comment #1
philbar CreditAttribution: philbar commentedI suspect this will make d7 also:
http://drupal.org/project/protect_critical_users
Comment #2
philbar CreditAttribution: philbar commentedFrom Lullabot:
In core for Drupal 7
51. CCK
52. FileField
53. ImageCache
54. Image Field
55. Poormanscron
56. Admin Role
57. Vertical Tabs
58. Token
Comment #3
philbar CreditAttribution: philbar commentedNeed to add the following lines of code to
upgrade_status.admin.inc
:Comment #4
klonosThis worked fine for:
- Token 6.x-1.x-dev
- Vertical Tabs 6.x-1.x-dev
Still, for the following modules and their respective versions there are issues...
- Content Construction Kit (CCK) 6.x-3.x-dev
shows a warning icon without any text to its left
'Includes: Content' as note instead of 'Renamed to Fields'
- Poormanscron 6.x-2.x-dev
status: In development
Recommended version: 7.x-2.x-dev (2010-Feb-20)
from the modules page: 'The 2.x versions are a backport of the automatic cron-running functionality included in Drupal 7.'
Comment #5
klonosAlso, Skinr 6.x-2.x-dev and Chaos tool suite 6.x-1.3 statuses look like In development with a warning icon but no 'In development' text to its left.
Comment #6
philbar CreditAttribution: philbar commentedI'm not sure why CCK, Skinr and Chaos tools don't have the "In Development" text. Since this is a seperate issue, I've created a bug report here:
#728608: Unsupported releases are missing status text
As for Poormanscron and CCK being in core but still listed as "In Development", I believe it is because Upgrade Status checks to see if there is a dev release for the module first, and then checks to see if it is in the list of modules which are marked as "In Core". This problem should get flushed out once these modules are either released as stable versions, or the dev releases are removed from the system.
Comment #7
klonosIf that is actually the situation, shouldn't it be changed so that 'In Core' status is checked first and if true then check for a dev release be skipped?
That won't be necessary if what I propose gets implemented.
Comment #8
philbar CreditAttribution: philbar commentedTechnically, everything should be marked as "In Development" at this point, since Drupal 7 hasn't been released.
This is a temporary problem, and I don't see why it won't be solved on it's own by the time Drupal 7 is released. We can re-evaluate this issue when D7 is released.
Comment #9
philbar CreditAttribution: philbar commentedComment #10
philbar CreditAttribution: philbar commentedAlso seems like we should add the following:
Comment #11
philbar CreditAttribution: philbar commentedIf this issue gets fixed in D7 #101227: Gzip aggregated CSS and JS
...consider CSS Gzip included in core.
Comment #12
sunhttp://www.unleashedmind.com/en/blog/sun/more-than-50-drupal-modules-mov...
Comment #13
sunAforementioned blog post was updated with 15 more modules.
Comment #14
philbar CreditAttribution: philbar commentedWow...and I thought the 8 listed by Lullabot was alot.
Nice work, sun!
Comment #15
klonos@sun ,#12, #13: Can we have the patch updated with those extra 15 ones and committed please?
Comment #16
klonos...btw, these modules should be denoted as 'In core' instead of 'Available'
Comment #17
sunSorry, I've tried to schedule an update for this patch a couple of times already, but wasn't able to do so.
Someone needs to go through the list of the blog post and double-check that every module listed therein is contained in this patch, and post an updated patch afterwards. Dead simple job.
Comment #18
klonoson to it...
Comment #19
klonosWhile I'm on it, I'll also add your notes from that article too. I need to ask this though...
I sometimes see this pair used:
<a href="!project-url">Project Name</a>
-'!project-url' => 'http://some.url.here'
in the
href
part of your <a> tags and this in some other cases:<a href="@project-url">Project Name</a>
-'@project-url' => 'http://some.url.here'
Which one is right the
@
or the!
? If either is fine, should I update them to one for consistency (which one then)?Comment #20
klonos...scratch that. Went here and RTFM as I should have done in the first place.
Comment #21
sun@ is the correct placeholder for URLs. The manual for t() is great, but a bit ambiguous regarding URLs, as it's using both ! and @ placeholders. Technically, ! can be used under certain conditions, but to be on the safe side, @ is always the right choice.
Comment #22
philbar CreditAttribution: philbar commentedEverything listed on the blog post has been added to the patch. Notes included.
Code was reviewed by Coder to verify it meets drupal standards.
Comment #23
philbar CreditAttribution: philbar commentedThere are 75 modules in the patch and 75 on the post.
Comment #24
philbar CreditAttribution: philbar commentedWe are missing:
Definitely in Core
Almost in Core
Mostly in Core
Comment #25
klonos@philbar: you got me to it, but...
#22: I thought we were placing the modules/project cases in alphabetical order. So, I was trying to do exactly that. I like your way better though, because we need to place some of the modules two or three together in some cases (and that breaks the alphabetical order thing anyways). A minor addition... since you've placed all those that got in 7.x core, might as well place a
@line 282 (just for consistency).
#23: Double checked and confirming this ;)
#24: thanx for the update on these! @sun: looks like you'll need to (re)update the article now ;)
When we set the version status text, we treat
UPGRADE_STATUS_STABLE
&UPGRADE_STATUS_CORE
the same and add a 'Available' status. This might confuse people when it comes to modules that were moved in core and they might go to the projects' pages looking for an available version (see #16). So, I think we should better have it like so instead:This brings another issue. It does mark modules as 'In core', but it still shows the 'warning' icon instead of the 'ok' icon. That's because in this part of the code:
...we treat modules with 'In core' status that include notes as if they still have known issues or something. So, we either need to remove notes from modules that are in core and will never get a 7.x version, or we need to figure out a better solution (I'll do some brainstorming and post more ideas on this latter).
...so I guess this goes back to NW.
Comment #26
klonosIn regard to the issue of modules in core still displaying a warning icon instead of ok...
Perhaps instead of checking whether there's a note or not, we should be checking if there is a 7.x version of the module available. This will also solve the issue with modules like CCK I guess (that should have a 'Available' status despite being in core or a 'Partially in core' perhaps).
...
Comment #27
sun@klonos: That's a different issue, not to be mixed or confused with this issue.
Comment #28
klonosI know (#728608: Unsupported releases are missing status text), I just thought we might find a solution to hit both in one go.
Comment #29
philbar CreditAttribution: philbar commentedI agree, there should be a better distinction with the addition of the following categories:
In addition to...
Comment #30
Aren Cambre CreditAttribution: Aren Cambre commentedsubscribe
Comment #31
philbar CreditAttribution: philbar commentedPatch Summary:
- Same as #22
- Added Protect Critical User and Contextual modules
- Removed check for modules which are in Drupal 6.x core since this is the D6 version of the module (Keep this in the D5 version)
- Instead of labeling the in core modules as "Available" they are now labeled "In Core"
- Since all modules have notes, removed code which said
if note = warning icon; else = ok icon
- Changed "else if" to "elseif" to match drupal standards.
Comment #32
philbar CreditAttribution: philbar commentedAs mentioned above, I removed the following code in the patch since everything has a note:
I assume this was a way to handle modules which are only partially in core or aren't exactly cloned in core.
Is there a better way to handle these cases? Perhaps we should open a new issue regarding "Partially In Core" designation.
Comment #33
philbar CreditAttribution: philbar commentedSame as #31 except "In Core" has been renamed to "In core" to be consistent with capitalization.
Comment #34
klonosI know that Poormanscron has a 7.x version available, but it finally got in D7 core. Still showing as 'In development' though (because a 7.x version is available).
Got both this and #728608: Unsupported releases are missing status text applied and they look good to go to me. The removal of the modules that are in D6 core from the 6.x version of Upgrade Status (but keep them in 5.x) was a great call philbar. Good thinking!
The only thing that looks kinda bad right now is that the module's cases are not listed alphabetically anymore. Could prove to be an obstacle for easy maintenance. On the other hand we've had a single D7 feature replacing more than one modules and I don't see an easy way to list those 'group cases' alphabetically somehow. Brainstorming on this one...
PS: don't let the last mentioned minor issue hold this back. I'll do some cleaning up (as in copy-pasting a few chunks of code here and there) once this is ready if and wherever possible.
Once again, thanx philbar!
Comment #35
philbar CreditAttribution: philbar commentedI think we should to open another issue related to partially in core modules. It's a bit out of the scope of this issue and with it's own issue we can focus on a clear solution for these cases:
- Poormanscron
- Image API
- Token
- CCK
- Better Formats
- Update status advanced settings
Comment #36
philbar CreditAttribution: philbar commentedIs the only issue left in this grouping modules messes up the alphabetical order? That's how the 5.x version did it, and as far as keeping this module maintainable, the "Find and Replace" feature of any code editor should be much faster than scrolling through the list.
Is this RTBC?
Comment #37
klonos...it is by me ;)
Comment #38
philbar CreditAttribution: philbar commentedComment #39
sunThanks for working on this! This looks very good already.
(and elsewhere) We do not want to remove the D6 definitions. There are users that are updating from D5 to D7.
However, it would be a good idea to insert all the new switch cases for D7 above the existing cases for D6, so we have them cleanly separated in the code.
All t() placeholder tokens that denote a URL should use a '-url' suffix to clarify for translators that the token contains a URL only; e.g., '@ctools-url' in this case.
Stale/bogus URLs?
Hm. The entirely copied wording of the blog post will not make sense for Upgrade Status module users. Including links to Drupal core issues is nice, of course, but we definitely want to only state important stuff in these notes. After all, you will have to read every single one, if there is one, to make sure that your upgrade will work safely.
At the very least, that has been the intention of those notes -- inform you about required additional actions, if core has included a functionality only partially.
Therefore, I think we should remove all notes that are pure marketing and just keep the ones that hold important information people will actually care for.
(and elsewhere) Trailing white-space here.
Powered by Dreditor.
Comment #40
philbar CreditAttribution: philbar commentedThis patch is for the D6 version of the module. A user upgrading from D5 to D7 would use the D5 version of the module which I agree, should include the D6 definitions. But the D6 definitions are useless in the D6 version of the module.
Comment #41
sunI guess you're right, but there's also no harm at all in keeping those definitions. Perhaps we'll be able to do statistics one day ;)
Reworked the patch based on the above. Also added a @todo about those help texts. Feedback welcome.
Comment #42
sunSorry, a syntax error slipped into that last patch.
Comment #43
sunThanks for reporting, reviewing, and testing! Committed this patch along with a major revamp of the entire module.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #44
klonos@sun, post #39:
Does that mean that this will provide the solution itself and that we won't be handling this in a separate issue?
Comment #45
klonos...by this I mean the 'Partially in core' thing. I am asking because I still believe there should be such a status as said in #29 and previously.
Comment #46
sunLet's open a separate issue for that and prepare some use-case scenarios. I've also added some inline comments about this already to take into account:
Powered by Dreditor.
Comment #47
philbar CreditAttribution: philbar commentedHere is the follow-up issue: #903060: Better handling for partially in core cases
Comment #48
sunhttp://www.unleashedmind.com/en/blog/sun/more-than-50-drupal-modules-mov... additionally notes
http://drupal.org/project/simple_menu_settings
http://drupal.org/project/node_menu_parent
Also not sure whether we've incorporated all further suggestions from earlier comments in this issue?
Comment #49
philbar CreditAttribution: philbar commentedI think we got everything, unless #101227: Gzip aggregated CSS and JS makes it into D7.
Comment #50
lpalgarvio CreditAttribution: lpalgarvio commentedif i'm not mistaken, Content Display Order feature has also been implemented on Drupal 7 as of at least alpha6.
it provides the CCK field reordering.
has no relation with Display Suite (or other modules like ctools/Panels, Composite Layout, etc), but overlaps with it at a minimum level (only reordering, no support for columns or custom code.
Comment #51
lpalgarvio CreditAttribution: lpalgarvio commentedadministration modules:
Comment #52
lpalgarvio CreditAttribution: lpalgarvio commentedhttp://drupal.org/project/moduleinfo feature is mostly/partially in D7 core (as Operations in the Modules page), depending on how you put it ^^
http://drupal.org/project/qamodules however did not; postponed for D8
Comment #53
klonospatch in #33 needs to be rerolled since the upgrade_status.admin.inc file is to be removed.
Comment #54
lpalgarvio CreditAttribution: lpalgarvio commentedpassword_change functionality seems to be also present in D7 core.
what is does is ask for current password, when editing a user profile.
btw, i patched it to work with phpass (also in core) module ;)
http://drupal.org/node/598692#comment-3613386
Comment #55
lpalgarvio CreditAttribution: lpalgarvio commentedpassword was backported to D6.
it's a better version of phpass, as it uses the password.inc file from D7.
it works by adding a second table for the new hashes, while preserving the old table with the md5 hashes.
i've also patched password_change to work with phpass and password modules.
-----------------
contextual is indeed a working similar module to D7 core's contextual, although not exactly the same or a backport. it was ported from admin 1.x module. it might get similar to D7 contextual in the future though.
contextual by swentel is a backport attempt of D7 core's contextual module. some modules got inspiration from it' code.
administertooltip could be considered a backport of D7, but it's more an evolution. there's a possibility that it will be ported to D7. it's more worth noting it as a similar module, and when the time comes, as having an upgrade path.
Comment #56
lpalgarvio CreditAttribution: lpalgarvio commentedthese 3 can be considered to be in core of d7:
deck (replaces the two bellow)
cck_teaser_field (looks abandoned)
cck_teaser (looks abandoned)
deck adds a separate field (stored in cck) to input the teaser... or optionally computes it from the body, the standard behavior
i've noted these also in the "Show suggested replacement for obsolete modules" issue
Comment #57
lpalgarvio CreditAttribution: lpalgarvio commentedtwo or three others:
- CSS Gzip
- Javascript Aggregator (might be like the previous)
- Tracker2 (check here)
Comment #58
sunRecent feedback as patch.
Comment #59
klonosThe Elements module is listed as 'In core'. I don't know if any part of its functionality is in D7 core, but still there is a 7.x version of it available and its project page has a #D7CX pledge too.
Comment #60
klonos...same happens for poormanscron, but I know for sure that this is in core. Still, the latest 7.x dev of the module is offered as an available update and it might confuse people to thinking that this is another CCK case where most of its features were included in core, but the 7.x version is there to provide features that did not make it into core. Perhaps an exception so that the 2010-Jul-11 7.x dev of the module is not displayed in the list?
Comment #61
Dave ReidElements.module is a testing ground for new FAPI elements to be included in core, so it will never always be all in core. And I disabled the poormanscron 7.x release.
Comment #62
Aren Cambre CreditAttribution: Aren Cambre commented#1025040: Improve upgrade status for CCK modules
Comment #63
mstrelan CreditAttribution: mstrelan commentedAnother module in core is ie_css_optimizer
Comment #64
lpalgarvio CreditAttribution: lpalgarvio commentedconfirming that Javascript Aggregator is in core, but partially.
it compresses JavaScript files, but does not Minify yet. the module does both.
as for CSS GZIP, it is in core entirely. this module is based on the code from Javascript Aggregator.
it compresses and minifies the code, like the module.
btw, you can use the code in .htaccess file from Drupal 7 core to do this compression in CSS/JS files in D6 without modules. you can also use that .htaccess code with these modules.
also in both D6 and D7, the core already aggregates the files and compresses the html. no change in that.
but there is no module to Minify the HTML yet.
Comment #65
lpalgarvio CreditAttribution: lpalgarvio commentedIE CSS Optimizer is also partially in core.
does about the same, except the module has settings for performance page.
Comment #66
lpalgarvio CreditAttribution: lpalgarvio commentedSystem Table Cleaner ?
Comment #67
lpalgarvio CreditAttribution: lpalgarvio commentedRole Weights
Role Weight
both are partially in Drupal 7 (drag and drop re-order of roles , permissions section)
probably only misses the API which is used by other modules, like Multiprice.
roleweight is deprecated in favor of role_weights
Comment #68
lpalgarvio CreditAttribution: lpalgarvio commentedAlready In functionality is part of D7 core.
The issue this module addresses has been fixed in Drupal 7, see #17664: user/register should show custom message instead of 403 for logged-in users.
Node Reference/Embed Media Browser (nrembrowser) is the suggested path upgrade to Media module in D7.
Comment #69
klonosHey LCPA, I see you've been doing some serious work locating these modules. Thanx mate ;)
Comment #70
lpalgarvio CreditAttribution: lpalgarvio commentedcopy paste of some reports from http://www.unleashedmind.com/en/blog/sun/more-than-50-drupal-modules-mov...
Comment #71
Aren Cambre CreditAttribution: Aren Cambre commented(Module is not a proper noun. Leave lowercase.)
Comment #72
lpalgarvio CreditAttribution: lpalgarvio commentedoops, sorry, i think i erased the title the other day by mistake and had to retype it
Comment #73
Kristen PolTriaging all Drupal 6 Upgrade Status issues. As Drupal 6 is no longer supported by this module and "In core" is already implemented in the Drupal 7 version, closing this.