HS works wonderful with multy-parented terms well with "save linage" option enabled.
I don't need "save lineage" option. But i need "force deepest" option. I have multiple parents vocabulary.
HS breaks in my case. It saves last used root term instead.
See pictures 1-4 for details.
P. S. Sorry for pieces of Russian text on screenshots.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fasdalf@fasdalf.ru’s picture

Title: multiple parents without "save lineage" saves parent only. » Multiple parents without "save lineage" saves parent only.
FileSize
8.33 KB
5.3 KB
6.03 KB
33.39 KB

Attached images was missing.

Wim Leers’s picture

Assigned: Unassigned » Wim Leers
Category: bug » support
Status: Active » Closed (works as designed)

That's not a bug, it's by design — it's a limitation of Taxonomy. This is clearly described in the README:

- In hierarchies where items can have multiple parent items and where you have
  enabled Hierarchical Select's "save lineage" setting, it is impossible to
  remember individual hierarchies, unless the underlying module supports it.
  So far, no module supports this. Hierarchical Select is just a form element,
  not a system for storing hierarchies.
  For example, if you have created a multiple parent vocabulary through the
  Taxonomy module, and you have terms like this:
   A -> C
   A -> D
   B -> C
   B -> D
   If you then save any two lineages in which all four terms exist, all four
   lineages will be rendered by Hierarchical Select, because only the four
   terms are stored and thus there is no way to recover the originally
   selected two lineages.
fasdalf@fasdalf.ru’s picture

Vocabulary has no "multy select" option enabled. Lineage, shown on edit page does not mean much in my case.
I need only last term saved. Core taxonomy saves term itself and shows first found parents during edit.
Core's taxonomy behaves exactly as i need, but it does not scale.
HS behavior is very strange. It does not save selected term as taxonomy does. It saves term's top parent. Why HS can't just show some (first found) lineage for multy-parented term?

Once again. One who disables "save lineage" does not care wich parents will be shown during node edit.

It does not matter, what shown on edit page: A->C or B->C. It's only matters to see "C" term under node teaser. Is it reasonable?

P.S. You didn't look at images at all, did you?

fasdalf@fasdalf.ru’s picture

Status: Closed (works as designed) » Postponed

I'm sorry, but i will repeat. I need only one trem, not lineage.
What's the problem?

Wim Leers’s picture

Title: Multiple parents without "save lineage" saves parent only. » Terms with multiple parents when "save lineage" is disabled: saves parent instead of term
Category: support » bug
Status: Postponed » Needs review
FileSize
1.35 KB

You say in your first post:

HS works wonderful with multy-parented terms well with "save linage" option enabled.

Which is confirmed in: http://drupal.org/files/issues/2%20terms_0_0.png (yes, I *did* look at your screenshots).
I never talk about a "multy select" option. Please work on your communication skills.

I understand what you mean now though. But that's the first time ever somebody has told me that they don't care which lineage is displayed.
And you're absolutely right: it shouldn't be misbehaving as badly as it is! So I've worked on a work-around that should make it work.

Patch attached. Please review. (See http://drupal.org/patch/apply.)

fasdalf@fasdalf.ru’s picture

Status: Needs review » Reviewed & tested by the community

I'm not stupid. I'm just russian :)
We call it "language barrier." Never mind.

I've tested patched hs_taxonomy in few hours and it works as core taxonomy does. It saves selected term now. There is no side effect found.

I hope to see it in next development build or release on project download page.

Thank you very much!

Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

Committed!

http://drupal.org/cvs?commit=336236
http://drupal.org/cvs?commit=336238

EDIT: I had forgotten, but I had this part of a reply already waiting:
Hey, I definitely understand your language isn't perfect. Just try even a little harder to improve it further (English is also not my native tongue). It'll give you a major advantage over other job applicants, too :)
I'm sorry if I came across as overly harsh. It's just that it's very difficult to help out if you're not using the exact terminology …
By the way: Russia FTW. It's very hard to kill a Lada (we've been driving Lada's for >20 years I think).

fasdalf@fasdalf.ru’s picture

Thank you for patch once again. Thank you for English practice too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.