Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Right as we run for the D7 alpha we have #653580: Upgrade to jQuery 1.4 and jQuery UI 1.8 alphas. We should release with the latest jQuery UI if at all possible.
Comment | File | Size | Author |
---|---|---|---|
#88 | Home text isn't disable.png | 139.34 KB | aspilicious |
#86 | jquery-ui-1-8_679036_86.patch | 266.61 KB | RobLoach |
#79 | jqueryui18.patch | 266.1 KB | RobLoach |
#77 | jquery-ui-1-8_679036_77.patch | 266.06 KB | mfer |
#77 | ui-anim_basic_16x16.gif | 1.52 KB | mfer |
Comments
Comment #1
lilou CreditAttribution: lilou commentedMark #680208: Upgrade jQuery UI to 1.8 as a duplicate of this issue.
Comment #2
webchickAdding to the alpha hit list. I don't think this'll make it in by then, but if it could have a patch ready to go with the current beta code that's been tested w/ jQuery 1.4, that'll help tremendously with getting it in as soon as possible.
Comment #3
RobLoachhttp://3281d.com/projects/improving-subscriptions
Comment #4
mikl CreditAttribution: mikl commentedThis would be a tremendous boon to we who tinker with JavaScript. The jQuery documentation has historically been rather poor for the previous version, though I suspect that will have improved with their new API site.
Comment #5
marvil07 CreditAttribution: marvil07 commentedHere is a starting patch, it rename the alpha zip files to the drupal ones, using the minified version, except for jquery.cookie.js because the zip file contains only the expanded version.
warning: overlay stop working after updating ui lib, and I'm not sure how to test this(I do not update jQuery lib since this jQuery UI 1.8a2 have the jquery-1.3.2.js on its zip)
Comment #6
marvil07 CreditAttribution: marvil07 commentedAbout testing js: JavaScript Tests at Testing and Quality Assurance group in g.d.o
Comment #7
mcrittenden CreditAttribution: mcrittenden commentedSub.
Comment #8
redndahead CreditAttribution: redndahead commentedFYI jquery ui 1.8b1 is out. Adds autocomplete awesomeness.
http://jqueryui.com/docs/Changelog/1.8b1
Comment #9
marvil07 CreditAttribution: marvil07 commentedComment #10
redndahead CreditAttribution: redndahead commentedAlso richard worth tweeted 1 week until 1.8 Seems a little quick for me for expecting 1 more beta and an rc, but thought I'd pass it along since it seems it will be released well before D7.
Comment #11
marvil07 CreditAttribution: marvil07 commentedhere a new patch that includes jQuery UI 1.8b1
Comment #12
mfer CreditAttribution: mfer commentedWhy is a compressed version of jquery.cookie.js being removed and replaced with an uncompressed version?
Comment #13
redndahead CreditAttribution: redndahead commentedRead #5. it's because the current zipped files contain the uncompressed version. I'm sure when 1.8 is released then the compressed one will come in the zip.
Comment #14
mfer CreditAttribution: mfer commentedMaybe a better question is what's the difference between jquery.cookie.js that we currently have and the version bundled with jquery ui 1.8b1
Comment #15
marvil07 CreditAttribution: marvil07 commentedNot sure what exact version drupal now have in core, but the version on the jquery ui zip is:
jquery-ui-1.8b1/external/jquery.cookie-r6165.js
So, it should be r6165 on the original repo.
Comment #16
zilverdistel CreditAttribution: zilverdistel commentedsubscribing
Comment #17
int CreditAttribution: int commentedwrong post
Comment #18
seutje CreditAttribution: seutje commentedRC1 was released http://jquery14.com/day-14 \o/
Comment #19
marvil07 CreditAttribution: marvil07 commentedhere a new patch that includes jQuery UI 1.8rc1
jQuery UI now ships jQuery 1.4.1, so we now depend on #653580: Upgrade to jQuery 1.4
Comment #20
mfer CreditAttribution: mfer commentedThis change is not just a simple case of updating files. jQuery UI 1.8 comes with some new stuff that needs to be defined in system_library() and the widget stuff from ui.core.js was broken out into ui.widget.js. This needs to be included in the dependancy chain for the widgets and effects to work.
Also, jquery ui changed the name of the files. They are all not prefixed with "jquery.". We should probably update to the new file names.
Comment #21
webchickOh sweet merciful crap. :\
Once this gets RTBC-ish, if someone could do me a HUGE favour and figure out the proper cvs add/remove commands I would love you forever (or if someone has a nice trick to deal with this mass rename issue I'm all ears).
Comment #22
casey CreditAttribution: casey commentedPatch of #19 does not apply to HEAD.
Comment #23
mfer CreditAttribution: mfer commented@webchick - I'll try to make sure it just works for you :)
Comment #24
marvil07 CreditAttribution: marvil07 commentedComment #25
marvil07 CreditAttribution: marvil07 commented@mfer: yep, that's the reason why I'm not changing the status to "needs review", but now I can :-)
@webchick:
cvs add misc/ui/effects.fade.js misc/ui/ui.autocomplete.css misc/ui/ui.autocomplete.js misc/ui/ui.button.css misc/ui/ui.button.js misc/ui/ui.mouse.js misc/ui/ui.position.js misc/ui/ui.widget.js
(they are only the newones)@casey: thanks for trying the patch :-), something strange here between vcs(re-rolling from cvs instead of dvcs :-p) .. so finally.. after some time dealing with cvs and actually reading how to add files in a patch for CVS(hint: cvsdo add).
Ok so, making a summary until how, here is the new patch, that:
- replace jQuery UI 1.8rc1
- add Id keywords on file headers.
- make the patch apply
- ui.stackfix(added in 1.8a1 or 1,8a2 IIRC) was removed in jQuery UI 1.8rc1, so remove it
- reflect new dependency chain in jQuery UI files
And now: overlay works again ;-)
Comment #27
casey CreditAttribution: casey commentedI am really sorry but it still doesn't apply correctly :)
Your patch is removing all code from various ui files.
Comment #28
casey CreditAttribution: casey commentedLooking at your patch I see multiple "\ No newline at end of file". These seem to prevent me from applying your patch. I believe its a Drupal standard to add a newline at end of every file.
Also, did you use the right commands? http://drupal.org/patch/create
Comment #29
marvil07 CreditAttribution: marvil07 commentedgreat hint casey.
yep actually the original jQuery UI used have files with different end of lines(unix/dos) and also files with no end new line of file, so that make it tricky.
I tried to avoid those problems by including it when necessary.
And now I try to apply the patch on a clean cvs checkout, so this time it should work :-)
Comment #31
marvil07 CreditAttribution: marvil07 commentedNot sure what's the problem here.
I used the way proposed on http://drupal.org/patch/create
Literally I did:
I tried to apply it on a clean checkout with success, like I mention:
Any ideas?
Comment #32
casey CreditAttribution: casey commentedNot really, but this should work :)
Comment #34
casey CreditAttribution: casey commentedNo it didn't
Comment #36
Pasquallesubscribe
Comment #37
nevergone CreditAttribution: nevergone commentedsubscribe
Comment #38
jide CreditAttribution: jide commentedsub
Comment #39
Remon CreditAttribution: Remon commentedsubscribe
Comment #40
marvil07 CreditAttribution: marvil07 commented#29: 0001-upgrade-to-jQuery-UI-1.8rc1-v4.patch queued for re-testing.
Comment #41
int CreditAttribution: int commentedjQuery 1.4.2 Released jQuery 1.4.2 Min
jQuery UI 1.8RC2 Released jQuery UI 1.8RC2
Comment #42
Jolidog CreditAttribution: Jolidog commentedCan a patch create a file if it doesn't exist? I think I read somewhere it can't, but I might be completely wrong.
The patch from #29 is trying to create these files:
misc/ui/effects.fade.js
misc/ui/ui.autocomplete.css
misc/ui/ui.autocomplete.js
misc/ui/ui.button.css
misc/ui/ui.button.js
misc/ui/ui.mouse.js
misc/ui/ui.position.js
misc/ui/ui.widget.js
with strings like these:
I think that might be the problem.
From the handbook page:
Does this help?
Comment #43
mfer CreditAttribution: mfer commented@Jolidog it can. when the final jquery UI 1.8 comes out i was planning on rolling a patch that just works.
Comment #44
marvil07 CreditAttribution: marvil07 commentedHere a new version of the patch with
1.8rc2
.About the non-applying patch.. well I'm following the next steps(form http://drupal.org/patch/create):
- change files
- add new files
- roll the patch
@mfer: It seems like you know how to do it in the right way(tm) :-), maybe you can suggest me how different your method is from the one I follow. I suppose 1.8 release is gonna be shipped with the right EOLs, so maybe that could make my problem disappear.
Like I said, I tried this patch in a new cvs checkout, and it applies clean, please try it :-)
About overlay module: It still works, but there is a bug on
#overlay-container
height(it only take your screen size, not all page in overlay size)About dependency: 1.8rc2 play well with 1.4.2, so AFAIK we need patch from #653580: Upgrade to jQuery 1.4, comment #90
About what is missing: Wait for jquery-ui 1.8 official relelase, with should include minified version of jquery.cookie.js
About why I re-rolling against 1.8rc2 instead of waiting for official 1.8: help testing drupal side js compatibility with a little more time.
So, hoping bot like this.. :-p
Comment #46
marvil07 CreditAttribution: marvil07 commentedAbout overlay module: It still works, but there is a bug on#overlay-container
height(it only take your screen size, not all page in overlay size)Rob Loach make that problem disappear :-) #653580: Upgrade to jQuery 1.4 (comment #91)
Comment #47
webchickSo, with the Overlay fixes in the jQuery 1.4 issue, is it possible to commit that patch and use it with jQuery UI 1.7.2 until 1.8 "proper" is out, or are they still co-dependent?
Comment #48
RobLoachI think with this patch, we should switch to jQuery UI 1.8's new naming convention with the filenames. jquery.ui.dialog.js as opposed to just ui.dialog.js.
@webchick
jQuery UI 1.7 is compatible with jQuery 1.4, which means we could commit the jQuery 1.4 patch and wait off on this issue until the final jQuery UI 1.8 is released.
@marvil07
I can't take credit for that one. Casey's doing!
Comment #49
marvil07 CreditAttribution: marvil07 commented#653580: Upgrade to jQuery 1.4 is commited :-)
Yep, that took me unnecessary time in renaming before I made the patches. I was really not sure if jquery ui was changing naming convention or if that was a "dev" naming convention :-p
So, totally agree in changing names to the new convention if it is :-)
BTW: can someone help me to understand why bot do not like the way I'm following(see my comments in this issue) to make patches? (note the patch applies manually)
Comment #50
aspilicious CreditAttribution: aspilicious commentedDetect invalid patch format
Ensure the patch only contains unix-style line endings.
You have to select unix style endigs...
If you're using eclipse you can configure that somewhere...
Comment #51
RobLoachThis patch names all the files the standard jQuery UI 1.8 naming and updates to jQuery UI 1.8rc3. The Overlay is working just fine from my testing.
Comment #53
Remon CreditAttribution: Remon commented#51: 679036.patch queued for re-testing.
Comment #55
aspilicious CreditAttribution: aspilicious commented@rgregory this patch contins windows endings, so it never will pass testbot
Comment #56
RobLoachThat's strange, because I made it on Linux.
Comment #57
mfer CreditAttribution: mfer commentedFYI, I've been just holding off on this until 1.8 is actually released.
Comment #58
webchickWe still need to test in advance of 1.8's official release so we can get this in quickly after, so interim patches are highly appreciated.
And apparently http://dev.jqueryui.com/query?status=accepted&status=assigned&status=new... is a list of their remaining criticals and blockers, but it's having a little trouble displaying atm.
Comment #59
neclimdulVery odd. I was rolling my own version of the patch, built in linux too so lets see if it works any better. I went ahead and ran dos2unix on everything including the ui files just to make sure...
Comment #61
aspilicious CreditAttribution: aspilicious commentedMaybe there is still an UI file with windows endings...
Strange...
Comment #62
oriol_e9gThis lines contain strange caracters.
Comment #63
neclimdulSorry, I think that is eclipse being lame. I'll take another look at it in a reasonable edit and see if I can sort that part out.
Is there some way to check if the test bot is giving us a false positive here? As I noted, I ran dos2unix on all the files so I can't see why it would be failing.
Comment #64
casey CreditAttribution: casey commentedAnother try
Comment #66
mfer CreditAttribution: mfer commentedEven though the formal announcement for jQuery UI 1.8 release has not gone out yet the tag has been created and the file download is in place. I'd expect the announcement soon. You can see them at http://code.google.com/p/jquery-ui/source/checkout and http://code.google.com/p/jquery-ui/downloads/list.
So, here is a patch and the one additional image that needs to be placed in /misc/ui/images
@webchick, I applied the patch against CVS head and it removed the old files (with the old naming convention) and added the new files with the new names.
I did some basic testing and it looked to work. I needs more testing, though.
Comment #68
mfer CreditAttribution: mfer commentedEvery one of the patches for this has failed. I wonder if there something with the jQuery UI files that is causing this problem. Or, is there something specific with the testing system I don't know about when adding/removing files?
Comment #69
mfer CreditAttribution: mfer commentedThere was a reference in the diff for the binary file from #66. Removed that. That file is still needed but it may not have liked it in the patch file.
Comment #71
aspilicious CreditAttribution: aspilicious commentedJust needs a reroll :)
Comment #72
mfer CreditAttribution: mfer commentedLets try this one more time. It seems there were extra carriage returns in the jQuery UI files causing some havoc. This requires the image from #66 as well.
Comment #73
aspilicious CreditAttribution: aspilicious commented"-webkit-border-top-left-radius: 4px/*{cornerRadius}*/; border-top-left-radius: 4px/*{cornerRadius}*/; "
This nice patch will make opera 10.50 and IE9 support rounded corners completly :)
Comment #75
mfer CreditAttribution: mfer commentedHere is a new patch with some missing content. oops. This is what I get for trying a new workflow on this patch.
Comment #77
mfer CreditAttribution: mfer commentedThis patch should work. Or, at least apply. There are 3 files here:
The 3rd file is included per webchicks request (see above). Some systems, like git, can remove files in a diff. CVS/patch cannot. So, here are the commands.
Comment #78
cosmicdreams CreditAttribution: cosmicdreams commentedSo far, Testing in Chrome and Firefox 3.5 have shown no errors as the result of the patch in #77
Comment #79
RobLoachI was getting some jirkiness with the Overlay without jQuery UI: Position alongside the Dialog. Also fixed a typo "Positionr'.
Comment #81
aspilicious CreditAttribution: aspilicious commented#77
Overlay not wroking
I think install animation (progressbar) not working
Comment #82
mfer CreditAttribution: mfer commented@aspilicious can you provide more detail. Like the Browser, version, and operating system you are having trouble on.
Comment #83
aspilicious CreditAttribution: aspilicious commentedI'll test again with a fresh install!
I'll provide details later.
Comment #84
aspilicious CreditAttribution: aspilicious commentedOk I was wrong #77 was working, just needed an new database and a fresh install.
What's the difference between #77 and #79??
Comment #85
RobLoachThere are three things different between #79 and #77....
Comment #86
RobLoachIt will probably hate this one too. It moves the dependency on "ui.position" over to overlay_library() rather than on "ui.dialog" itself.
Note the instructions mfer posted at #77.
Comment #87
casey CreditAttribution: casey commentedGreat! Patch doesn't seem to bring any huge problems along.
Comment #88
aspilicious CreditAttribution: aspilicious commentedthis related?
NOP it isn't related!
Ignore screenshot!
Comment #89
webchickOk, committed this to HEAD. Thanks for all of the epic efforts getting a patch to work with testing bot, and thanks to mfer for the list of rm commands to run.
It would be lovely for someone to double-check and make sure this made the transition okay; CVS is a complete pain in the ass. :P~
Comment #90
ClearXS CreditAttribution: ClearXS commentedHi, installed jQuery UI 1.8 + same for the themes 1.8 in the jQuery UI themes dir on Drupal 6. Then the "jQuery UI update" module and copying files to /misc dir.
Ofcourse it was not working, so I found this patch. But:
* It seems to be for Drupal 7 only, so Drupal 6 patch is still missing?
* I don't understand exactly what (part of) which different files I have to change and exactly where in my Drupal install;
* I'm not sure if I first have to install the jQuery UI (&themes) version 1.7 before installing 1.8?
Anyway, I suppose that -untill these questions have been answered and a patch for Drupal 6 exists- I have to install jQuery UI version 1.7 to get it working on my Drupal? Right now the module is there, but I'm unable to vink it on; it's blocked saying that it depends on jQuery UI what 'seems' to be missing.
Comment #91
webchickDrupal 6 is API frozen, so will never be including jQuery UI. Restoring issue properties.
People who want to use jQuery UI on Drupal 6 will need to use the jQuery Update and jQuery UI modules. Not sure the answers to your questions, but they'd be for those queues, not the core queue.
Comment #92
RobLoachYou probably want #749126: JQuery Plugin 1.8 is out.