I was having a look at the module and was kind of hesitant to try it further after seeing it required to modify a core file.

It is only a slight change and would be easy to include it as a patch to be run when updating, but in the spirit of all good things Drupal, I was wondering if there wasn't a solution to avoid that patch all together.

It seems that what you're asking to add to common.inc is to have the url rewritten to handle sessions on Docomo cellphones.

Might I suggest to have a look at this nice little module and see if this would let you achieve the result you seeked:
http://drupal.org/project/url_alter

There also a core drupal function to rewrite the inbound and outbound urls, but it requires you to write the rules in setting.php which is a bit ackward (that's why url_alter was written to solve and those hooks are now part of D7 core). Here's a reference to it: http://api.drupal.org/api/function/custom_url_rewrite/5

Please let me know what you think and thank you for this module.

Comments

Antoine Lafontaine’s picture

Antoine Lafontaine CreditAttribution: Antoine Lafontaine commented

sorry, d6 references:

http://api.drupal.org/api/function/custom_url_rewrite_inbound/6
http://api.drupal.org/api/function/custom_url_rewrite_outbound/6

jajathejazzcat’s picture

jajathejazzcat CreditAttribution: jajathejazzcat commented

Hi Antoine. Thanks for the references.

I agree with you completely and prefer not to hack core whenever possible.
I'll try the modules you mentioned and if they work, I'm all about removing the hacks.

jajathejazzcat’s picture

jajathejazzcat CreditAttribution: jajathejazzcat commented

I've tested hook_url_outbound_alter() with url_alter.module, and it works beautifully. Thanks, Antoine!
I've committed the change to HEAD and 6.x-1 branch. The included jp_mobile_helper module now depends on url_alter.module, and no longer requires hacking the core.
It you have already modified the settings.php as described in the previous version of README.txt (I've also updated the README.txt), you should change back the url_rewriter.tags to the default setting as follows.

ini_set('url_rewriter.tags',        '');

Since the url rewriting is now done by hook_url_outbound_alter(), this change will avoid appending a session ID to urls twice.

Antoine Lafontaine’s picture

Antoine Lafontaine CreditAttribution: Antoine Lafontaine commented
Status: Active » Closed (fixed)

This is great news!

Closing this since I guess it can be considered fixed.