Decouple Location of htmlpurifier Library with Libraries API [#708266]

Comment	File	Size	Author
#1	htmlpurifier-library.patch	3.17 KB	wik

File	Size
htmlpurifier-library.patch	3.17 KB

Comment #2

ezyang CreditAttribution: ezyang commented 9 February 2010 at 00:26

Status:

Needs review

» Postponed (maintainer needs more info)

Thanks for the patch! I'm trying to figure out how to make this transition work properly without breaking users autoinstalls (as it stands, if they don't have the libraries API installed and they update their files, everything breaks horribly).

Log in or register to post comments

Comment #3

wik CreditAttribution: wik commented 9 February 2010 at 21:40

Easiest way it's to bundle/utilizing libraries API(two methods) with module, prefixing methods with "htmlpurifier_", but I would consider this one only if there no other choice :)

It's could be done as BC wrapper, which could check if there libraries API installed already and use it if so, or use simplified internal methods if it's not installed.

Log in or register to post comments

Comment #4

ezyang CreditAttribution: ezyang commented 9 February 2010 at 21:53

I've posted an issue here: #709526: How to gracefully add support for libraries

I've hacked in a BC layer on my local copy (I can share if others are interested), but there's another interesting problem namely now you can't /disable/ the module.

Log in or register to post comments

Comment #5

j0nathan CreditAttribution: j0nathan commented 22 February 2010 at 18:48

subscribing

Log in or register to post comments

Comment #6

ezyang CreditAttribution: ezyang commented 8 March 2010 at 07:00

Status:

Postponed (maintainer needs more info)

» Needs work

#709526: How to gracefully add support for libraries was resolved. Blocking on me removing the dependency and making sure everything checks out.

Log in or register to post comments

Comment #7

TravisCarden CreditAttribution: TravisCarden commented 10 April 2010 at 20:07

Sweet! Subscribing.

Log in or register to post comments

Comment #8

TravisCarden CreditAttribution: TravisCarden commented 27 April 2010 at 22:58

Title:

decouple location of htmlpurifier library

» Decouple Location of htmlpurifier Library with Libraries API

Making title more "skimmable".

Log in or register to post comments

Comment #9

ezyang CreditAttribution: ezyang commented 11 May 2010 at 21:36

I spent some cycles today looking at the new approach, and I've found that we need to be careful about cases in which a user has an old-style installed HTML Purifier, and then they install libraries. Patch needs more work.