Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Right now when you have several lines on your invoice and remove the first one by deleting its description and price, all subsequent lines disappear without warning.
Perhaps a "delete" checkbox could be placed next to each line.
Cheers,
Albert.
Comment | File | Size | Author |
---|---|---|---|
#7 | storm--items-07.patch | 1.43 KB | juliangb |
#2 | storm--758974-2.patch | 1.86 KB | juliangb |
Comments
Comment #1
juliangb CreditAttribution: juliangb commentedDefinitely not the intended behaviour.
A neater way of doing the lines of the invoice would be to display one line, and add/remove lines via ajax or something similar.
Comment #2
juliangb CreditAttribution: juliangb commentedI think this will solve it - but disclaimer, I haven't tested this yet.
Let's see first whether the testbot likes it, then whether it has the intended result.
Comment #3
juliangb CreditAttribution: juliangb commentedMaking sure this patch is still valid.
#2: storm--758974-2.patch queued for re-testing.
Comment #4
juliangb CreditAttribution: juliangb commented*Bump* for review.
Comment #5
tchurch CreditAttribution: tchurch commentedI tried this.
warning: Invalid argument supplied for foreach() in /home/sites/example.co.uk/public_html/central/sites/all/modules/storm/storminvoice/storminvoice.module on line 727.
Everything still disappears.
Comment #6
juliangb CreditAttribution: juliangb commentedNeeds to be fixed in 2.x first.
Comment #7
juliangb CreditAttribution: juliangb commentedPatch for review.
Comment #8
juliangb CreditAttribution: juliangb commentedI believe from my tests that this now fixes the issue.
I will wait 1 week before committing to let others test.
As a bug, this would be backported to 1.x.
Comment #9
kfritscheworks for me.
Comment #10
juliangb CreditAttribution: juliangb commentedThanks for the feedback.
Marking for commit.
Comment #11
juliangb CreditAttribution: juliangb commentedCommitted to 2.x.
Retest on 1.x.
Comment #12
juliangb CreditAttribution: juliangb commented#7: storm--items-07.patch queued for re-testing.
Comment #13
dbt102 CreditAttribution: dbt102 commentedDoes not quite (completely) work for me...
I created a test invoice and posted three separate items. First Item I assigned a weight of 1, amount of $1000. 2nd a weight of 2, amount $2000. Then third item a weight of 3, amount of $3000. The printed invoice looked the way I expected.
Then I went and removed the third item (with weight of 3). And it removed that item leaving the other two.
However, when I removed just item with weight # 2 - by removing the description, price and weight - the last two items disappear.
And, starting over again with test items 1, 2 & 3 ... If I remove test item #1 - created 1st with weight of 1, it wipes out all three test items.
Am I doing doing something wrong? Do I need to enable ability to delete items from invoice in a preferences tab somewhere?
Comment #14
juliangb CreditAttribution: juliangb commenteddbt102: thanks for testing. It should work out of the box. Did you apply the patch manually or test the 2.x-dev release? Might be worth double checking that the fix was contained in the version you tested - as it worked ok in my tests, which were very similar to yours.
Would you be able to check and report back?
Comment #15
juliangb CreditAttribution: juliangb commentedI've retested this using the current 2.x-dev release without any modifications, and the setup described by dbt102 - all seems to now work. I suspect maybe the issue was that the -dev release hadn't been rebuilt when it was tested previously.
Given that, I have also committed to 1.x.