Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After upgrading from beta2 to version 2.0 it saves fields from "Advanced options" of SingleFrame mode like this:
"field: value\nfield2: value" instead of "field: value", "field2: value" (see view source of js code generated)
Comment | File | Size | Author |
---|---|---|---|
#8 | 777990-isnumeric-1.patch | 1.63 KB | redndahead |
#7 | views_slideshow_js.patch | 772 bytes | alexromao |
Comments
Comment #1
redndahead CreditAttribution: redndahead commentedthat's how it should look what problem are you having?
Comment #2
redndahead CreditAttribution: redndahead commentedComment #3
redndahead CreditAttribution: redndahead commentedMarking as fixed
Comment #4
alexromao CreditAttribution: alexromao commentedI got the same problem after the upgrade to Slideshow 2.0.
On FF 3.6 only the first parameter set on the "Advanced options" box is working, all other parameters are ignored.
On IE 8 no paramter set will work.
Comment #5
redndahead CreditAttribution: redndahead commentedCan you first upgrade to 2.1 and then if possible link to a site that is having the problem or send me the settings javascript output that can be found in the source of your page?
Comment #6
redndahead CreditAttribution: redndahead commentedComment #7
alexromao CreditAttribution: alexromao commentedHi,
sorry for the late response.
I've managed to fix the problem which seemed to be an iteration variable that got overwritten in the
views_slideshow.js file (calling the
IsNumeric()
function).This was the primary cause for a
for
loop just executing 1 iteration only, and all other additionaladvanced parameters where just ignored.
here is a patch to fix this problem.
Comment #8
redndahead CreditAttribution: redndahead commentedThanks L3X that was a good catch. I changed the patch up to declare the variable in the function so that it is local. Can you please test the attached patch.
Comment #9
alexromao CreditAttribution: alexromao commentedHi,
I've tested the patch and it works just fine.
For both Slide shows, singlefram- and thumbnailhover-slideshow.
I'd say it's fixed.
Comment #10
redndahead CreditAttribution: redndahead commentedthis has been committed.