I have a design that requires rounded edges on the first and last pager items.

I was a little surprised that the classes for pager items were hard-coded into the Javascript. I was even more surprised to find out that, although the classes for 'odd' and 'even' were there, the classes for 'first' and 'last' were not.

I have attached a simple patch that adds these classes.

CommentFileSizeAuthor
#16 20130626143234.jpg190.47 KBwangqizhong
#10 views_slideshow-pager_first_last-782166-10.patch2.25 KBigor.ro
#8 views_slideshow-pager_first_last-782166-8.patch2.26 KBjeffschuler
#5 views_slideshow-pager_first_last-782166-5.patch2.24 KBjeffschuler
#1 views_slideshow.patch38.21 KBRoloDMonkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey commented
FileSize
views_slideshow.patch38.21 KB
redndahead’s picture

redndahead CreditAttribution: redndahead commented

good idea on the first and last classes. The reason they are hard coded into SingleFrame was pagers were an after thought and I was using the pager support in jQuery cycle. If you want stronger control of your pagers I would look at thumbnailhover.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Status: Needs review » Fixed

This has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Version: 6.x-2.0 » 7.x-3.x-dev
Status: Closed (fixed) » Needs review
FileSize
views_slideshow-pager_first_last-782166-5.patch2.24 KB

I'm not seeing 'first' and 'last' classes on pager items in 7.x-3.x. This patch adds them.
It also breaks up a couple long lines of code (into <80 char lines.)

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Needs review » Needs work

the patch #5 works well,

but I'd prefer to insert "views-row-first" and "views-row-last" classes instead of "first" and "last"

(for odd and even is used "views-row-odd" and "views-row-even")

robertom’s picture

robertom CreditAttribution: robertom commented
Assigned: RoloDMonkey » Unassigned
jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented
Status: Needs work » Needs review
FileSize
views_slideshow-pager_first_last-782166-8.patch2.26 KB

Point taken. Looks like that's how Views usually does it anyway.
Thanks for reviewing!

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Needs review » Reviewed & tested by the community

Thanks for the new patch!

igor.ro’s picture

igor.ro CreditAttribution: igor.ro commented
FileSize
views_slideshow-pager_first_last-782166-10.patch2.25 KB

New patch for 7.x-dev version

wangqizhong’s picture

wangqizhong CreditAttribution: wangqizhong commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot to RoloDMonkey, redndahead, jeffschuler, robertom, igor.ro and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at:

6.x-2.x: 5bf14e2.

6.x-3.x: fe544f9.

7.x-3.x: bda8444.

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

matthieu_collet’s picture

matthieu_collet CreditAttribution: matthieu_collet commented

hello

I've just installed the 7.x-3.x-dev and the problem is still there, no first and last classes

is there any patch for this version ?

thank you

wangqizhong’s picture

wangqizhong CreditAttribution: wangqizhong commented

Sorry, I can't reproduce this issues. Could you try to use the latest 7.x-3.x-dev and double-check the HTML class?

matthieu_collet’s picture

matthieu_collet CreditAttribution: matthieu_collet commented

it's the last version : 7.x-3.0+24-dev

you can see my test here :
http://www.dethier.be/en/projets/welkenraedt-funeral-centre
no first & last for the rows/slides

wangqizhong’s picture

wangqizhong CreditAttribution: wangqizhong commented
FileSize
20130626143234.jpg190.47 KB

You can use Firebug or Chrome Developer Tools, it is easy to search called "views-row-first" and "views-row-last" of classes (attached).

matthieu_collet’s picture

matthieu_collet CreditAttribution: matthieu_collet commented

yes, it has just changed with last updates, all seems ok now

thank you