Installing latest 6.x dev, the Local time zone doesn't work.
This is critical not only because it is major functionality, but also because it is a release blocker and a new release is very much needed due to #758294: Time changes to incorrect time (now fixed).

I hope to get at this in the next few days.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

The problem is that when JS is turned off, 'Local' is passed to date_format_date() directly, which it cannot handle. This is a regression introduced by #742028: Sync 6.x and 7.x / Code clean-up
With JS on, it must also be something related to the former issue. I am not sure yet, though, what it is. Will roll a patch for the first one shortly.

tstoeckler’s picture

Status: Active » Needs work
FileSize
2.64 KB

This is preliminary patch. It fixes the local time issue.
Changing the date format, doesn't work for me. I don't know if it is related to this issue, though.

tstoeckler’s picture

Status: Needs work » Needs review
FileSize
3.87 KB

What a dumb error. I don't know how that snuck in there.
Anyway, with the code-clean-up I can only hope this won't happen again.
Everything is working for me now.
I really feel anxious to release a new version now, but I should probably wait.

tstoeckler’s picture

FileSize
6.16 KB

I had committed the above patch before (http://drupal.org/cvs?commit=368094).
It wasn't 100% functional though. New patch attached which fixes everything and also cleans up the tests, so that they actually work. Therefore we only have to test the JavaScript related functionality, which I did and it works. I will wait before committing this, to see how the Testbot likes this.
I will release 1.2 after this commit though.

tstoeckler’s picture

Status: Needs review » Fixed
tstoeckler’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Needs review
FileSize
26.58 KB

For D7.

tstoeckler’s picture

Status: Needs review » Fixed
FileSize
27.32 KB

Slight failure in display tests. Committed this. Maybe this fixes the Simpletest-ing of the D7 branch.
http://drupal.org/cvs?commit=372340

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.