Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The attached patch adds a 'buffer' and a 'ratio' params to WMS layers.
Parsing of the string to number is done in JS, which I don't like, but I didn't find a good example
of doing it in the PHP side (form validation).
Comment | File | Size | Author |
---|---|---|---|
#2 | BufferRatioWMS_2.patch | 1.73 KB | strk |
BufferRatioWMS.patch | 2.49 KB | strk | |
Comments
Comment #1
tmcw CreditAttribution: tmcw commentedThis has some console logs in it, and could you specify the radix (add a second parameter of 10) to the parseInt function?
Comment #2
strk CreditAttribution: strk commentedIn the new patch firebug calls removed and radix added
Comment #3
tmcw CreditAttribution: tmcw commentedCommitted in http://drupal.org/cvs?commit=372484
Thanks for all of the work with WMS layers!
Comment #4
strk CreditAttribution: strk commentedNot sure which commit broke it (if this or singleTile one) but anyway current branch misses a comma by the end of line 77 of wms.inc
Comment #5
tmcw CreditAttribution: tmcw commentedGood catch, fixed. I basically applied the patches in opposite order to how you wrote them, I'd guess, so this one went above when it would have gone below and wouldn't have needed a comma? Maybe? Anyway, just committed a comma.
Comment #6
strk CreditAttribution: strk commentedYes, indeed git found the code in HEAD with those behaviours order swapped