On /admin/content/node --
Check the 'Select all' checkbox in the non-floating header, the floating header remains unchecked.
Check the 'Select all' checkbox in the floating header, uncheck it in the non-floating header, the floating header remains checked.
Check the 'Select all' checkbox in either header, uncheck any other checkbox, the non-floating header is unchecked (correctly), the floating header remains checked.
Comment | File | Size | Author |
---|---|---|---|
#22 | core_js_select_all_sticky-218470-22.patch | 780 bytes | Albert Volkman |
#19 | core-js-select-all-sticky-218470-17-D7.patch | 783 bytes | Albert Volkman |
#17 | core-js-select-all-sticky-218470-17-D7.patch | 783 bytes | nod_ |
#17 | core-js-select-all-sticky-218470-17.patch | 803 bytes | nod_ |
#14 | tableselect-tableheader.patch | 919 bytes | casey |
Comments
Comment #1
LAsan CreditAttribution: LAsan commentedConfirmed. Same happens in 7.x-dev.
Comment #2
redndahead CreditAttribution: redndahead commentedHere is a patch to include the cloned header on update. One thing that this patch will miss is when the select all box is checked on page load. The issue is the cloned table header is loaded after the update of the select all box on the initial load. Not sure when this will come up.
EDIT: Nevermind on the initial load the js will clone the checked state also.
Comment #3
drewish CreditAttribution: drewish commentedi wonder if it's related but i'd noticed that the header isn't fully cloned when it start floating. if you set a class on the fixed header once it starts floating the formatting is lost until it stops floating.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedThe last submitted patch failed testing.
Comment #5
redndahead CreditAttribution: redndahead commentedNow improved with a reroll and 4 less bytes. Get it now while it's hot.
Comment #7
redndahead CreditAttribution: redndahead commentedComment #9
redndahead CreditAttribution: redndahead commentedHmm don't see how this patch could make the file naming test fail. Maybe bad result? Moving back to review
Comment #10
cburschkaI have submitted the patch for re-testing.
Comment #12
webchickComment #13
catchI can't see the select all checkbox in the floating table header at all (ff3/ubuntu) - with or without the patch.
Comment #14
casey CreditAttribution: casey commentedEven smaller patch.
I do see the select-all checkbox (FF3/XP).
Comment #15
casey CreditAttribution: casey commentedStill applies. anyone?
Comment #16
casey CreditAttribution: casey commented#14: tableselect-tableheader.patch queued for re-testing.
Comment #17
nod_just a reroll, don't credit me.
Works fine, 'nuf said :)
Comment #18
catchComment #19
Albert Volkman CreditAttribution: Albert Volkman commentedReuploading nod_'s D7 patch from #17 for testbot.
Comment #20
nod_Comment #21
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/efd12ac
Moving to 6.x for possible backport.
Comment #22
Albert Volkman CreditAttribution: Albert Volkman commentedD6 backport.