I'm using the recommended Rubik theme with the Tao theme and the options for expanding/collapsing groups using the +/- icons no longer work, I have to disable the display setting in my firebug to view/edit these parameters now, I tried to fix this by using jquery_update but to no prevail.

Comments

fuse’s picture

Same here. I don't know if this is an Admin module issue or a Rubik/Toa theme issue.

yhahn’s picture

Just to clarify, you are talking about fieldset expanding & collapsing and not the admin toolbar?

Also, are there any javascript errors that might help me debug this for you?

fuse’s picture

No javascripts errors. We are talking about the fieldsets not expanding or collapsing.
Tried enabling and disabling javascript optimization but that doesn't change anything either.

Reported this issue in the Rubik theme too, but looking at the replies the most bug reports get, I don't think there will be much response.

yhahn’s picture

Status: Active » Closed (duplicate)
sampeckham’s picture

Status: Closed (duplicate) » Needs review

Not convinced this a Rubik issue as its works fine for me in Firefox and Safari, but not in IE. Turning off admin theme fixes the issue in IE.

Plus the error IE gives is:

Message: 'attr(...)' is null or not an object
Line: 84
Char: 15
Code: 0
URI: http://www.MYSITE.org/sites/all/modules/admin/includes/jquery.drilldown.js?I
 for (var key in breadcrumb) {
            if (breadcrumb[key]) {
              // We don't use the $().clone() method here because of an
              // IE & jQuery 1.2 bug.
              var clone = $('<a></a>')
                .attr('href', $(breadcrumb[key]).eq(0).attr('href'))
                .attr('class', $(breadcrumb[key]).eq(0).attr('class'))
                .html($(breadcrumb[key]).eq(0).html())
                .addClass('depth-'+key)
                .appendTo(trail);

I might be wrong but the theme has been fine for me before beta 5 in all browsers. Switched to review for someone to check my logic, feel free to switch it back if I'm out of order!

sampeckham’s picture

It looks there are two separate issues with the same symptom. I followed the github thread above and added the theme updates, it may have worked for the guys there for Firefox, but makes no difference for IE and I still get the same JS error as I posted above.

Can we reopen this issue as an Admin module issue with IE 8 please?

[PS. The beta 5 update totally fixed the bugs with the admin toolbar itself - which is great! Just this little hangover issue now]

yhahn’s picture

@sampeckham I've made a couple of commits (http://drupal.org/project/cvs/480736) for IE-related fixes but I wasn't actually able to reproduce the issue you are talking about.

A couple of questions:

  • If I interpret correctly, it's only the fieldset toggle that doesn't work and only in IE8 when using Rubik. That means
    • All other JS behaviors (e.g. the admin menu drilldown) works?
    • When you switch to another theme (e.g. Garland) everything works?
    • This is only in IE8? What about IE8 + compatibility mode (aka IE7)
  • Are you using the latest versions of Rubik and Tao? (2.0-beta2, 2.1)
sampeckham’s picture

Hi Yhahn

Thanks for picking up on this thread, sorry not to reply sooner, got pulled off onto other things.

Once I started looking at your questions it gets more interesting!

  • With the Rubik theme I get the following:
    • Admin menu drilldowns don't work (+ icons) but 'My Account', 'Administer' 'Create Content' switching does.
    • +/- fieldsets don't work either
    • Conditional Fields module doesn't hide fieldsets (where I first noticed this problem)
    • This applies to both IE8 and compatibility mode
  • With the Garland theme I get:
    • Admin menu drilldowns did work in IE8 not in compatibility, but switched back to IE8 and they stopped working!
    • Collapsed fieldsets don't open the feildset name is not a link just text
    • Conditional Fields module doesn't hide fieldsets
  • I am using the lastest version of Rubik, Tao and Admin
  • Disabling Conditional Fields module and clearing cache enables the admin menu drilldown but not collapsing fieldset - true of both themes but still little temperamental

If there is anything else I can try let me know - happy to help test/debug.

sampeckham’s picture

Just to add, i've tried turning off admin module and turning on conditional fields, all under Rubik.

Conditional Fields and Fieldsets now work fine with Admin module off.

yhahn’s picture

Do you have access to a JS console like Firebug or WebKit inspector? I'm wondering if there are any javascript error messages you can provide.

sampeckham’s picture

I do on the Mac side of things, but everything works fine in both Safari and Firefox, so I'm not seeing errors even reported there.

On IE 8 (compatibility mode off) I'm using the developer tools. Running the debug picks up the same issue I posted above in #5.

'attr(...)' is null or not an object - the highlighted code in the debugger is below (Line 84 char 15 of jquery.drilldown.js?l and is showing the path to the admin module includes folder)

var clone = $('<a></a>')
                .attr('href', $(breadcrumb[key]).eq(0).attr('href'))
                .attr('class', $(breadcrumb[key]).eq(0).attr('class'))
                .html($(breadcrumb[key]).eq(0).html())
                .addClass('depth-'+key)
                .appendTo(trail);

At this stage the Admin menu is working correctly, even the drilldowns. But the main page +/- fieldsets are still failing.

If there is another/better IE tool I can run to help track this down let me know.

sampeckham’s picture

Thought I'd post the jquery version if that helps and in closing the debug window and trying to go to the status reports the admin menu drilldown stopped working! So still a bit hit or miss.

Anyway, here's my setup.

Drupal 6.17 - a couple of security updates behind now, maybe an issue?
jQuery UI 1.8 - should this be 1.7 perhaps?
jQuery update 1.2.6
Admin 6.x-2.0-beta5 - is the new rc1 worth trying instead?
Rubik 6.x-2.0-beta2
Tao 6.x-2.1

chrsc’s picture

Embarrassing moment :P so after a bunch of troubleshooting, and of course I figured out why it wasn't working when I updated the Tao theme. Its because Tao needs to be re-enabled once updated. Soon as I re-enabled the theme everything started to work again.

Also note, that I have updated from admin-6.x-2.0-beta5 to the latest admin-6.x-2.0 release. Also updated to the latest Rubik release (rubik-6.x-2.0-beta6) and Tao-6.x-2.3.

Cheers,
Chris

lelizondo’s picture

Version: 6.x-2.0-beta5 » 6.x-2.0-rc1

was this solved? I'm also having this problem with IE7/8/9 when Admin module is enabled.

bagelzorg’s picture

I had the same problem when running zen sub theme with quicktabs on the page.

A fix for the javascript which seems to work is something along the lines of:

if (breadcrumb[key] && $(breadcrumb[key]).html() != undefined) {
rather than if (breadcrumb[key]) {

Sometimes it gets a second breadcrumb entry which is .html() = undefined.

Not graceful fix, but will work and might shed some light on devs working on module.

mstrelan’s picture

Version: 6.x-2.0-rc1 » 6.x-2.x-dev
Status: Needs review » Active

I am also getting this error as described in #5 but the fix he mentioned did not work. I am using a custom theme built from scratch.

- JQuery Update 2.x
- JQuery UI 1.7.x
- Drupal 6.20
- Admin 6.x-2.0

shiroitatsu’s picture

Sama problem with 7.x-2.0-beta3 on OS X and Chrome. Works well on Firefox.