Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.based on aaron comment about Red/green color blindnessand its prevalence: about 10% of people, I think it's a good idea to change the colors.
I'm really bad for design :-p, if someone can help me with an image with the example widget I could make it real I think ;-)
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | vote_up_down-816776.patch | 14.22 KB | Soren Jones |
| #13 | vote_up_down-816776.patch | 14.22 KB | Soren Jones |
| #11 | vote_up_down-816776.patch | 17.76 KB | Soren Jones |
| #11 | arrows.png | 968 bytes | Soren Jones |
| #11 | plus.png | 262 bytes | Soren Jones |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedupps
Comment #2
marvil07 CreditAttribution: marvil07 commentedComment #3
Soren Jones CreditAttribution: Soren Jones commentedIMHO, the colors aren't an accessibility issue.
One arrow pointing right that was either green or red would be an issue.
Although red and green do have meaning for many people who can distinguish between the two colors, with an up and down arrow, the colors really aren't functional, they're decorative.
However, as you think it's a good idea to change the colors, for maximum aesthetic compatibility with a variety of themes, maybe both arrows should be the same neutral color (e.g. black).
Comment #4
marvil07 CreditAttribution: marvil07 commentedWhen I was working on #811694: New widget for splitting of votes in positives/negatives (5 voted up, 2 voted down) and I was deciding with the help of two designers about how the widget should look like, they suggest me the same, use one color for the two arrows.
Anyway, finally I end up using two colors, so this also make sense for the upanddown widget.
Comment #5
marvil07 CreditAttribution: marvil07 commentedComment #6
Soren Jones CreditAttribution: Soren Jones commentedSomething to get you started.
Comment #7
marvil07 CreditAttribution: marvil07 commentedI like how this looks like in black/white colours.
Thanks for the patch!
Actually I remember alternate widget also uses colours, so adding it to the list.
Comment #8
marvil07 CreditAttribution: marvil07 commentedupps
Comment #9
AntiNSA CreditAttribution: AntiNSA commentedI really dont like the red and green too. In China, red meants positive. Look at the symbol for the Chinese stock market.
I think black and white in a box would be cleaner.
Comment #11
Soren Jones CreditAttribution: Soren Jones commentedSynching with HEAD and adding grayscale images for alternate and upanddown widgets.
Comment #13
Soren Jones CreditAttribution: Soren Jones commentedSee #11 for the png files.
Comment #15
madjr CreditAttribution: madjr commentedsub
Comment #16
Soren Jones CreditAttribution: Soren Jones commented#13: vote_up_down-816776.patch queued for re-testing.
Comment #17
Soren Jones CreditAttribution: Soren Jones commentedSame patch.
Comment #18
marvil07 CreditAttribution: marvil07 commented@Soren Jones: sorry for the big delay and huge thanks for the patches :-)
I just make a little change on plain arrows to avoid that they look in a continuous figure.
So, patch committed to 3.x.
Comment #19
Soren Jones CreditAttribution: Soren Jones commentedNo worries. (^^)v And thanks for the review and the fix. \(^^)/