Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hello, the module is working great form me except:
"Registered authors can get notifications about comments on their nodes" its not working.
Node author is not getting notificacion unless he has commente his own node.
Comment | File | Size | Author |
---|---|---|---|
#8 | 774826_use_defaults_if_user_has_none.patch | 1000 bytes | greggles |
#5 | comment_notify-862730-5.patch | 825 bytes | danylevskyi |
Comments
Comment #1
Melissamcewen CreditAttribution: Melissamcewen commentedSame here.
Comment #2
neek CreditAttribution: neek commented+ same with dev version 1.x
i think it can be critical, cause it is default option for node author.
subscribed.
Comment #3
danylevskyi+1
I think it can be critical too.
Comment #4
danylevskyiI think here (http://drupal.org/node/849780) is discussed same problem.
Comment #5
danylevskyiHi guys, here a solution of the problem!
Comment notify module sends email to the node's author after checking database table "comment_notify_user_settings". This table contains user ids and their settings for notifying. Module fills this table during "comment" and "user" hooks. And sometimes, especially new users, doesn't have their rows in the table and as a result module doesn't send mail.
My solution is very simple. It checks variable "node_notify_default_mailalert" if "comment_notify_user_settings" doesn't have the row with current user and depends on it's value sends or doesn't send mail.
Here my patch. Please, test it.
Sorry for my English.
Comment #6
neek CreditAttribution: neek commentedi will check it soon! spasibo
Comment #7
gregglesBetter status.
Comment #8
gregglesI fixed this a slightly different way in #774826: node_notify_default_mailalert not respected.
I've marked that as a duplicate of this. Could you folks test out the attached patch?
Comment #9
rfayHmm. This is a critical I think.
However, without actually reviewing the code it appears to me that it doesn't work.
I created a node as one user, commented on it as another user, had the appropriate checkbox set in admin/settings/comment_notify. No email notification was generated to the node author.
Thanks for the excellent work on this everybody.
Comment #10
this_is_it CreditAttribution: this_is_it commentedit's really good.
a finely, delicate patch.
Comment #11
rfayI question my report in #9, so if it's not the same as other people's experience should be disregarded.
Comment #13
rfayI've had this deployed on warmshowers.org for several months and it works as advertised. I have found nothing wrong with it.
Nice work, and thanks.
Comment #14
gregglesFixed - thanks Randy http://drupalcode.org/project/comment_notify.git/commit/c95c1f2