Very easy feature request - increase the size of the e-mail subject box on the admin/user/invite/settings page. Right now it is limited to 30 characters, but using the token module with replacements you can very easily fill up the box. For example, including a single content profile field such as [profile-field_givenname-raw] already takes up 29 of the 30 available characters.

This would be done via editing invite_admin.inc and changing the #size in the following area of the code:

  $form['email']['invite_subject'] = array(
    '#type' => 'textfield',
    '#title' => t('Subject'),
    '#default_value' => variable_get('invite_subject', t('[inviter-raw] has sent you an invite!')),
    '#size' => 30,
    '#maxlength' => 64,
    '#description' => t('Type the default subject of the invitation e-mail.') .' '. t('Use the syntax [token] if you want to insert a replacement pattern.'),
    '#required' => TRUE,
  );

I would suggest changing it to something fairly lengthy, such as 90 characters to allow for token replacement space. Thank you.

CommentFileSizeAuthor
#8 496894-subject.patch1.41 KBsmk-ka
#2 invite.patch756 bytesseutje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rjbrown99’s picture

Actually it's probably #maxlength and #size, but I think you get the idea.

seutje’s picture

FileSize
756 bytes

+1

it's only maxlength, size is just the width of the box, which should fall back to the default imo

patch attached removes maxlength and size altogether

rjbrown99’s picture

Status: Active » Needs review
andypost’s picture

Status: Needs review » Reviewed & tested by the community

+1 to remove limit. As rfc 2821 and 2822 says - subject is unstructured field and have no limit but

rfc2822.txt 2.2.3. Long Header Fields

Each header field is logically a single line of characters comprising
the field name, the colon, and the field body. For convenience
however, and to deal with the 998/78 character limitations per line,
the field body portion of a header field can be split into a multiple
line representation; this is called "folding".

chrisdawson’s picture

I'd also like to vote for this patch to be committed, please

smk-ka’s picture

Status: Reviewed & tested by the community » Fixed
FileSize
1.41 KB

If we increase the length of the admin field, we need to also increase the length in the front-end. Committed the attached patch. Thanks to the spammer for bringing this issue to my attention.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.