The attached patch fixes a couple of compatibility issues with PostgreSQL, without hopefully breaking anything in MySQL (but it is untested on MySQL). Specifically, it fixes

1) a query error caused by the use of double quotes instead of single quotes, and
2) an encoding error that would happen when refreshing browscap data.

Please review and, possibly, merge into the next release.

CommentFileSizeAuthor
browscap-module.patch978 byteslifepillar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I was unsure about the change with %b to remove the ''. From reading http://api.drupal.org/api/function/db_query it says that it's correct to use %b without enclosing it in ''.

This looks good to me.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: PostgreSQL compatibility issues » PostgreSQL compatibility issues in browscap
Status: Needs review » Fixed

Now fixed - http://drupal.org/cvs?commit=415002

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.