Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Please, find below two patches implementing missing hook_uninstall to clear system variables.
Comment | File | Size | Author |
---|---|---|---|
hs_taxonomy-with-uninstall.patch | 564 bytes | dimi_did | |
hierarchical_select-with-uninstall.patch | 788 bytes | dimi_did | |
Comments
Comment #1
Wim LeersThanks! Committed, after I made some changes to your patch (there were some minor mistakes).
http://drupal.org/cvs?commit=417828
Comment #2
Wim LeersComment #3
voxpelli CreditAttribution: voxpelli commentedThis patch breaks hierarchical_select.install - it adds a new hierarchical_select_uninstall() but there already exists one so PHP throws a fatal error when trying to redeclare it.
Comment #4
Wim LeersFixed: http://drupal.org/cvs?commit=417878.
@dimi_did: epic fail of you for not testing your code at all. Epic fail of me for not reviewing it carefully enough.
HS 3.5 release will be out in a couple of minutes.
Comment #5
Wim LeersAnd the title was *still* wrong. Another fail. Meh.
Comment #6
benoit.borrel CreditAttribution: benoit.borrel commented@Wim Leers #4: dimi_did patch was developed against 6.x-3.3 for which it works perfectly. I was ready to submit the fix for 6.x-3.4, but you seem to be about to release 6.x-3.5, so I'll pass my turn.
:-)
Comment #7
Wim Leers@benoit.borrel: False. I applied it to 3.3 and that was part of 3.4. It's what broke 3.4, since hook_uninstall() was already implemented.
Comment #8
benoit.borrel CreditAttribution: benoit.borrel commented@Wim Leers: sorry but, according to:
there were no hook_uninstall() implemented yet in 6.x-3.3.
dimi_did and I had pair developed and tested the patches for 6.x-3.3 and we didn't get any PHP fatal error for function redefinition. Next time we will provide the tests too.
:-P
Comment #9
dimi_did CreditAttribution: dimi_did commentedAbsolutely. Wim, we are sorry about that but we tested it successfully with 6.x-3.3 release. Happy if it's working well now ;-) !
Comment #10
Wim LeersIn that case, completely my bad. My apologies!
Comment #11
amal850720 CreditAttribution: amal850720 commented@wim leers: epic confusion. lol. thanks anyway wim.