Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See the attached snapshots, the pager links looks much closer and makes it difficult to click appropriate link.
Comment | File | Size | Author |
---|---|---|---|
#20 | pager1.png | 6.68 KB | dcrocks |
#20 | pager2.png | 7.14 KB | dcrocks |
#20 | pager3.png | 7.63 KB | dcrocks |
#12 | Seven_theme_pager_spacing-759244-12.jpg | 9.47 KB | Mac_Weber |
#11 | Seven_theme_pager_spacing-759244-11.patch | 671 bytes | Mac_Weber |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedI don't know... hmmm
Comment #2
james.elliott CreditAttribution: james.elliott commented+1 to the extra spacing
Comment #3
yoroy CreditAttribution: yoroy commentedI'd much rather see work put into #538788: Implement Seven pagers as designed
Comment #4
rickvug CreditAttribution: rickvug commentedIs modifying the css reset the best place to do this? I would think that the change should go into style.css. There is an argument to be made that the reset is overly aggressive, but that should be dealt with at #723392: Tame seven's reset.css.
As for the change itself, I think that it is a welcome improvement. The spacing is maybe 2-5px too wide for my liking but I'd be bike shedding to request a change. :) Let's try to get this simple change in now in case #538788: Implement Seven pagers as designed doesn't make it.
Comment #5
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented@yoroy we are too late read Bojhan's comment #24
@rickvug Adding all selector to reset.css is not a good way either. This is addressed in #723392: Tame seven's reset.css so this issue will be fixed when #723392 is committed.
Comment #6
corbacho CreditAttribution: corbacho commentedI like this change and we are late to make it "as designed", so maybe this patch should be re-considered.
It's difficult to click correctly on the numbers. BUT maybe not so wide. Too much for my liking (as rickvug said)
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedseven-pager.patch queued for re-testing.
Comment #8
droplet CreditAttribution: droplet commentedComment #9
droplet CreditAttribution: droplet commentedseven-pager.patch queued for re-testing.
Comment #11
Mac_Weber CreditAttribution: Mac_Weber commentedI added
As in Bartik theme.
Comment #12
Mac_Weber CreditAttribution: Mac_Weber commentedresult's screenshot
Comment #13
afeijoit worked, congrats
Comment #14
Mac_Weber CreditAttribution: Mac_Weber commentedIt works in both 7.x and 8.x
Comment #15
Mac_Weber CreditAttribution: Mac_Weber commentedComment #16
dcrocks CreditAttribution: dcrocks commentedWhat does this look like to someone who normally runs their browser at 18pt?
Comment #17
yoroy CreditAttribution: yoroy commenteddcrocks, why do you ask? Your question lacks info on why that is important to check.
Not sure on the need (possibility) to backport this but looks good, fixes things in the right place. Thanks for the work and screenshots Mac_Weber.
Comment #18
dcrocks CreditAttribution: dcrocks commentedIt does look nice. But, since he uses 'em's for spacing will it look nice at larger fonts? It may not be a big deal here, but the UI has to work for everyone and these things should be considered. Don't stop this because of me, but permit the question.
Comment #19
webchickdcrocks: Can you test it and let us know how it works, rather than asking someone else to? :)
Comment #20
dcrocks CreditAttribution: dcrocks commentedFirst I had to find something on my test site that actually showed a pager. Found the system log report. The samples are firefox on a mac.
#1 no patch, 16pt font default
#2 patch, 16pt font
#3 patch, 18pt font
Still looks OK to me but some might dislike the whitespace. The only possible problem is if pager displayed in a fixed width block the pager object could unexpectedly overflow with larger fonts.
Comment #21
droplet CreditAttribution: droplet commentedRemind: system module is using EM. Please also submit a patch for it if it need to be PX.
Comment #22
Jeff Burnz CreditAttribution: Jeff Burnz commentedGeneral rule of thumb is if the text can scale 200% and nothing breaks then its good. ems should be fine - as long as the pager still works OK when it wraps, it good also.
Comment #23
Mac_Weber CreditAttribution: Mac_Weber commented@dcrocks you can always use drush+devel to generate content. Thus you would get a pager on your content management page
drush dl devel && drush en devel_ge* -y && drush genc 200
Comment #24
webchickThe screenshots at #20 look fine to me, sounds like others are in agreement as well.
Committed and pushed to 8.x and 7.x. Thanks!