Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The function definition uses $new_keys, but the parameters lists $keys_new.
Comment | File | Size | Author |
---|---|---|---|
#10 | db_add_field-new-930784-D6.patch | 644 bytes | daniels220 |
#8 | db_add_field-930784-D6.patch | 623 bytes | daniels220 |
Comments
Comment #1
Jaypan CreditAttribution: Jaypan commentedEdit: I notice that the key is actually called $keys_new for Drupal 7. My report is in reference to the Drupal 6 documentation.
Comment #2
jhodgdonGood catch. Probably the doc was ported from D7 and someone forgot to change the parameter name.
Comment #3
jhodgdongood project for a novice doc contributor
Comment #4
Jaypan CreditAttribution: Jaypan commentedIs that a hint? :D
Comment #5
jhodgdonSure. :)
We have this "Novice" tag to mark issues that are good for newbies, or for anyone who wants a quick project to do. If you'd like to do this one, please do. Just assign it to yourself, make a patch, attach it, and change the status to Needs Review.
Comment #6
daniels220 CreditAttribution: daniels220 commentedThis problem looks fixed on the docs page. Does that mean this issue can be closed?
I'm just getting started contributing, btw, so please correct me if I missed something obvious.
Comment #7
jhodgdonIt doesn't look fixed to me on that page.
The Parameters section has the parameter name $keys_new, but the function itself uses $new_keys.
Comment #8
daniels220 CreditAttribution: daniels220 commented...I am not having a good day today, am I. Well, here's a patch.
Comment #9
jhodgdonPatch formatting is not OK, wrong file names at top
Comment #10
daniels220 CreditAttribution: daniels220 commentedRegenerated with git.
Comment #11
jhodgdonthanks, that looks fine
Comment #12
Gábor HojtsyCommitted, thanks.