Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow up from Data's #922868: Don't allow commas in tag names.
When mapping terms to tag vocabularies and these terms contain commas, the terms will be at first not split up. Only when editing and saving the node they will be.
Fix coming.
Comment | File | Size | Author |
---|---|---|---|
#10 | feeds-925264-10.patch | 933 bytes | cedarm |
#1 | 925264-1_tags.patch | 887 bytes | alex_b |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedThis is RTBC.
Comment #2
alex_b CreditAttribution: alex_b commentedCommitted.
http://drupal.org/cvs?commit=443308
Comment #3
Thoor CreditAttribution: Thoor commentedI am using FEEDS 6.BETA-10 and still have the problem, that TAGs from a CSV URL are not separated, as you can see in my Posting from yesterday:
http://drupal.org/node/957654
EDIT: When I use BETA-09 or BETA-08 the mapping works fine for the Taxonomy Terms in the CSV File! So I guess that http://drupal.org/cvs?commit=428902 should maybe removed or at least edited?
Comment #5
lyricnz CreditAttribution: lyricnz commentedThis is a really annoying change. Previously, when consuming RSS feeds that had comma-separated values (eg: keywords), and mapping these into a Tag vocabulary, this worked "as expected", and saved as individual terms. Now, it creates one big term, with all the terms squished together :/
Comment #6
matt_stoltz CreditAttribution: matt_stoltz commentedIm not sure if this is something new, but this has cropped up again when I updated a few weeks ago to 6.x-1.0-beta10. All of my taxonomy terms for feeds that have been updated (some 400k nodes) have all be squashed together. This is really annoy and cuts down on the functionality of my site: www.shoeidiot.com
Thanks for reading
-Matt
Comment #7
matt_stoltz CreditAttribution: matt_stoltz commentedOn further digging I found why this change was implemented:
A related bug report:
http://drupal.org/node/957654
The first bug report:
http://drupal.org/node/922868
With both sides having valid points and reasons (Those that want commas in the terms themselves, and those who use commas to separate terms), and with my recognition of a "mini-mod" to change the taxonomy deliminator this would seem to be fixed. (Although personally, I'll just be rolling back to Beta9 for the time being).
My request would be: Could this become an option in a further build, one to allow commas in the term, and one to use them to separate values?
My main concern would be future mod updates that may render what ever fix I use to allow commas (or another deliminator) would then be rendered obsolete at some point, and cause problems down the road.
Thanks for reading; great module.
- Matt
Comment #8
lyricnz CreditAttribution: lyricnz commentedCreated #997392: Add support for tag-delimiters in taxonomy mapper
Comment #10
cedarm CreditAttribution: cedarm commentedI'd like to respectfully challenge this commit. I understand why it was done, but I don't think just stripping commas is the right answer. Parsers supply an array of terms, right? So why can't we use drupal_implode_tags() to properly store even weird tags in $node->taxonomy?
This patch reverts #1 and provides a replacement. Tested with tags from drupal_explode_tags(), supplied as an array from the parser:
Comment #11
mindgame CreditAttribution: mindgame commentedI agree to use drupal_explode_tags().
Let's do it the standard way. :)
My suggestion for the 7.x version is here:
http://drupal.org/node/1039134#comment-4235274
Comment #12
twistor CreditAttribution: twistor as a volunteer commented