Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Notice: Undefined property: panels_views_plugin_row_fields::$field_alias in panels_views_plugin_row_fields->render() (line 172 of /Users/clark/Documents/sites/latc-project.eu/sites/all/modules/panels-HEAD/plugins/views/panels_views_plugin_row_fields.inc).
I get that notice when I use Panel Fields in Views. I am using the latest HEAD of both modules.
The code in question is:
foreach ($this->region_fields as $region_id => $fields) {
$this->view->field = $fields;
$content[$region_id] = theme($this->theme_functions(), array('view' => $this->view, 'options' => $this->options, 'row' => $row, 'field_alias' => $this->field_alias));
}$this->field_alias is not set on the panels_views_plugin_rows_fields object. Since this is styling multiple fields, using views_view_fields.tpl.php, is $this->field_alias even applicable?
When I remove the 'field_alias' element in the array, it works and no notices are displayed.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | panels-notice-978768-13.patch | 861 bytes | mgifford |
| #11 | 978768_#10_notice_panels_7.x_3.4.patch | 959 bytes | alamp |
| #8 | 978768_notice_panel_fields_d6.patch | 748 bytes | WorldFallz |
| #4 | view-showcase.txt | 8.92 KB | boabjohn |
| #1 | 978768_notice_panel_fields.patch | 1.04 KB | linclark |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedPatch just in case I'm correct.
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedI think that patch is probably right. field_alias isn't used unless the row style adds a field, which this one does not.
Comment #3
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted!
Comment #4
boabjohn CreditAttribution: boabjohn commentedSorry, not sure if my troubles are related, but same error. Both Panels and Views are in 7.x-3 alpha1
Attached is problem View.
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commentedPlease note that it is absolutely impossible to get the exact same error while this patch is applied, because it changes the characteristics of the line in question. So clearly #4 is not exactly correct. My guess is that it's using a -dev from prior to this commit and this was not verified by #4.
Comment #6
Letharion CreditAttribution: Letharion commentedComment #8
WorldFallz CreditAttribution: WorldFallz commentedThis still exists in views 3 d6-- patch attached.
Comment #9
WorldFallz CreditAttribution: WorldFallz commentedComment #10
mgiffordNote, I just got this issue with 7.x-3.3 & Views7.x-3.7.
Notice: Undefined property: panels_views_plugin_row_fields::$field_alias in panels_views_plugin_row_fields->render() (line 92 of /var/www/psac/sites/all/modules/contrib/panels/plugins/views/panels_views_plugin_row_fields.inc).
Comment #11
alamp CreditAttribution: alamp commentedMe too, I just got this issue with 7.x-3.4 & Views7.x-3.7.
I'm attaching the patch for Panel 7.x-3.4
Comment #13
mgiffordComment #16
mgiffordDid this get committed or was that a bug? Not sure what's up in #14. I shouldn't be able to re-apply the patch (and I can) so I'm guessing it didn't get in (or perhaps was reverted).
Comment #17
MustangGB CreditAttribution: MustangGB commentedThe commit was at line 169, the patch is at line 89, looks there there are/were two occurrences.
Comment #18
DamienMcKenna@ashwinsh created a fix for this in #2543478: A typo in the code? too.
Comment #19
DamienMcKennaComment #20
DamienMcKenna@maximpodorov uploaded a patch to fix the exact same bug in #2117451: Undefined constant view too.
Comment #22
japerryFixed!