Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hello
Some modules attempt to preload jCarousel to jQ and after that, when jcarousel tries too, it fails.
This patch solves that.
Patched against v1.1.
Comment | File | Size | Author |
---|---|---|---|
#1 | jcarousel.module.patch | 793 bytes | lpalgarvio |
#1 | jcarousel.module.0.2.5.patch | 1.24 KB | lpalgarvio |
#1 | jcarousel-6.x-1.x-dev-LPCA.tar_.gz | 121.59 KB | lpalgarvio |
jcarousel-6.x-1.1-LPCA.tar_.gz | 120.71 KB | lpalgarvio | |
jcarousel.module.patch | 793 bytes | lpalgarvio |
Comments
Comment #1
lpalgarvio CreditAttribution: lpalgarvio commentedand for v1.x-dev...
also supplying a second patch with support for jCarousel 0.2.5 (/jcarousel/lib/jquery.jcarousel.jsmin.js changes to /jcarousel/lib/jquery.jcarousel.min.js)
i think it works fine even though we don't have jQuery updated to 1.4.2.
but do test ;)
Comment #2
quicksketchThis patch puts the jQ code in the wrong place I think. It should probably be inside of jcarousel_add(), not inside a theme function. The theme layer shouldn't be making adjustments based on whether jQ is available or not.
Comment #3
quicksketchThe jQ support no longer exists in the 2.x version of the module. My general opinion of jQ and other attempts to consolidate JavaScript libraries were ill-placed. I'd prefer not to support jQ or any other solution, unless one clearly becomes the defacto-standard. Right now it seems like the attempts sort of peaked around 2009 and then fizzled out. Of course D7 includes "library" support through #attachments, which will probably be the only solution that really gets widespread adoption.
Comment #4
quicksketchLPCA is now making the same pitch for Libraries API in #909094: Support libraries directory and Libraries API. jQ, well, can't say I'm surprised it didn't take off.
Comment #5
lpalgarvio CreditAttribution: lpalgarvio commentedagain, your response wasn't exactly in a timely fashion
sorry