On block editing page, before context override, getting notices:

# Notice: Undefined property: stdClass::$system in context_ui_form_block_admin_configure_alter() (line 213 of .../context/context_ui/context_ui.module).
# Notice: Undefined property: stdClass::$cid in context_ui_form_block_admin_configure_alter() (line 217 of .../context/context_ui/context_ui.module).

And "Edit visibility" link go to context list page instead of editing page

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones’s picture

Issue tags: +Context-2.1

Visual inspection looks good, need to test and add an extra break to the last case statement.

Steven Jones’s picture

Status: Needs review » Needs work
+++ context_ui/context_ui.module-patched	2010-08-18 11:48:39.701406568 +0300
@@ -210,11 +210,15 @@ function context_ui_form_block_admin_con
+            case CONTEXT_STORAGE_NORMAL:
+              $row[] = l(t('Edit visibility'), "admin/build/context/{$context->cid}", $options);

Needs a break; after these lines.

Powered by Dreditor.

Steven Jones’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
1.2 KB

Tested, and added the break.

Steven Jones’s picture

Status: Reviewed & tested by the community » Fixed

Added to 2.x in http://drupal.org/cvs?commit=468850

Thanks for the patch! (again)

Status: Fixed » Closed (fixed)
Issue tags: -Context-2.1

Automatically closed -- issue fixed for 2 weeks with no activity.