A couple of these need work -- patch is at http://drupal.org/node/968404#comment-3851236

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Status: Active » Needs work
FileSize
1.86 KB

This is the patch from over there.

However, API says:

> IMPORTANT NOTE: To maintain database portability, you have to explicitly recreate all indices and primary keys that are using the changed field.

and we have this:

> 'primary key' => array('nid', 'image_size'),

Hence needs work.

sun’s picture

Status: Needs work » Fixed
FileSize
2.18 KB

Thanks for reviewing, good spot! Committed to D6.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

heyyo’s picture

with the last dev I still have this schema errors :

column nid - difference on: unsigned
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'int', 'unsigned' => TRUE, 'not null' => TRUE, 'default' => 0)
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'int', 'not null' => TRUE, 'default' => 0)
column fid - difference on: unsigned
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'int', 'unsigned' => TRUE, 'not null' => TRUE, 'default' => 0)
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'int', 'not null' => TRUE, 'default' => 0)
indexes fid: missing in database
joachim’s picture

Where do you get that message?
Also, I don't see the text ''TODO: please describe this field!'' in either Image module or core.

sun’s picture

Status: Fixed » Active

Schema module produces such messages, when checking the actual database table schema against the module-defined schema.

@heyyo: Do you know which version of Image module you initially installed?

heyyo’s picture

I really don't know which version I started to use, but it was a long time ago...maybe in january 2009 with acquia distribution of drupal 6. Never mind I created an index on fid with phpmyadmin.

sun’s picture

Status: Active » Fixed

After closely inspecting the update functions once again, update 6100 should have set the correct schema info already. I can only guess that this update already ran on your site.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.