Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When a user is asked to select mailing lists in their edit newsletters page, it would be nice to display the description of each list (e.g. the taxonomy description).
This can be done with #type=>checkbox rather than checkboxes, and adding the #description.
Thanks,
Comment | File | Size | Author |
---|---|---|---|
#7 | simplenews-subscription_form-descriptions.patch | 7.8 KB | pillarsdotnet |
#4 | simplenews-subscription_form-descriptions.patch | 7.95 KB | pillarsdotnet |
Comments
Comment #1
Sutharsan CreditAttribution: Sutharsan commented+ 1 for adding subscriptions
-- 1 for using type 'checkbox'. Use a #theme instead.
Comment #2
Sutharsan CreditAttribution: Sutharsan commentedChanging title because taxonomy will die in Simplenews D7.
Some more thoughts: Newsletter description maybe usefull in 'public' newsletter forms, not on admin pages.
Comment #3
samalone CreditAttribution: samalone commented+1 for adding the newsletter description below the newsletter title when subscribing
I'd like to see this on both the newsletter/subscriptions page and when editing subscriptions for an account (user/3/edit/newsletter).
Our site maintains separate high-frequency and low-frequency newsletters for people with different preferences, and having the descriptions on the subscription pages would help users figure out which newsletter they should subscribe to.
Comment #4
pillarsdotnet CreditAttribution: pillarsdotnet commentedThe provided patch adds descriptions to newsletter subscribe/unsubscribe checkboxes. It also links newsletter names to issue lists (for user-accessible form) or options editing form (for admin-accessible form).
Comment #5
miro_dietikerWe need to check those changes one by one after applying. Thanks for your suggestion.
In general this issue is/was about "adding description" only...
Note that this patch will produce some collision with
#805114: Cleanup Form creation processes
So we should apply it before starting on the form cleanup for D7.
Comment #6
miro_dietikerAssigning
Comment #7
pillarsdotnet CreditAttribution: pillarsdotnet commentedSame patch, minus the links.
Comment #8
DrupOn CreditAttribution: DrupOn commentedPatch applied in D7 version of simplenews. committing to cvs within the next few days.
Comment #9
DrupOn CreditAttribution: DrupOn commentedCommitted to dev with some cleanup regarding newsletter form keys.
Comment #10
pillarsdotnet CreditAttribution: pillarsdotnet commented