In the views slideshow template we only check for isset($top_widget_rendered), which is always going to be set because of line 81 in views_slideshow.theme.inc.

It should check for !empty rather than isset, to avoid the surrounding div to be rendered.

CommentFileSizeAuthor
#1 1031176-views_slideshow-empty-check.patch1.49 KBsnufkin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

snufkin’s picture

snufkin CreditAttribution: snufkin commented
Status: Active » Needs review
FileSize
1031176-views_slideshow-empty-check.patch1.49 KB

Patch does just that.

Bevan’s picture

Bevan CreditAttribution: Bevan commented

I confirmed this fixes the bug, and also that it applies to the 6.x version.

I found #844800: IE background (?) display problem which was probably actually duplicate of this.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Status: Needs review » Fixed

Committed.

Bevan’s picture

Bevan CreditAttribution: Bevan commented

Thanks! :)

Did you apply to the 7.x version only? Or 6.x too?

redndahead’s picture

redndahead CreditAttribution: redndahead commented

both

Bevan’s picture

Bevan CreditAttribution: Bevan commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.