I was able to quickly and easily make an events calendar. http://events.econet.sk.ca However, when you click on an event title in the calendar view, the event opens in a new window. How do I change that?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

John Yates’s picture

Title: target » target window
aspilicious’s picture

Status: Active » Fixed
aspilicious’s picture

Status: Fixed » Active

Tim, this is the second time we get this request should we make it an option (under jquery UI theme and colorbox)?

tim.plunkett’s picture

Version: 6.x-1.3 » 7.x-2.x-dev
Category: support » feature

Yup.

aspilicious’s picture

Assigned: Unassigned » aspilicious

Assigning to myself...

aspilicious’s picture

Assigned: aspilicious » Unassigned
FileSize
2.04 KB

Here is a patch.

aspilicious’s picture

Status: Active » Needs review
tim.plunkett’s picture

Not sure if the dependencies can do this, but could this checkbox be hidden if colorbox is checked, since this won't take effect in that case.

aspilicious’s picture

That was easy :)

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

I love adding features that don't affect current users unless they care.
Will commit later today.

drseussofporn’s picture

*Wakes up* What? We can adjust the target window now? I care!

tim.plunkett’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Michsk’s picture

port. port. port! :P

glennpratt’s picture

Status: Patch (to be ported) » Needs review
FileSize
2.42 KB

Ported...

John Yates’s picture

Works great -- thanks.

Jon Nunan’s picture

I'm using the 7.x.2.x dev and there seems to be a slight bug with the patch applied in #9. The field has a dependency on the colorbox checkbox being unchecked; and I get the reason why you need to check for that. But because I don't have the colorbox module installed at all that field doesn't even exist in my form so the dependency is failing. Sorry I don't know enough about ctools for any sort of elegant workaround, but I'd like a way to select 'same window' without having to install colorbox.

For a quick hack I just commented out the dependency line, but this is obviously not the way to go for colorbox users.

aspilicious’s picture

Correct I'll fix this :)

aspilicious’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

Fix in my test branch: http://drupal.org/node/1092518/git-instructions/newWindowFix/nonmaintainer
Timplunkett, I'm prety sure it works :)

Old code

    $form['modules']['fc_window'] = array(
      '#type' => 'checkbox',
      '#title' => t('Open events in same window'),
      '#default_value' => $this->options['modules']['fc_window'],
      '#process' => array('ctools_dependent_process'),
      '#dependency' => array('edit-style-options-modules-fc-url-colorbox' => array(0)),
    );

new code

    $form['modules']['fc_window'] = array(
      '#type' => 'checkbox',
      '#title' => t('Open events in same window'),
      '#default_value' => $this->options['modules']['fc_window'],
    );

    if (module_exists('colorbox')) {
      $form['modules']['fc_window']['#process'] = array('ctools_dependent_process');
      $form['modules']['fc_window']['#dependency'] = array('edit-style-options-modules-fc-url-colorbox' => array(0));
    }
pjcdawkins’s picture

There's a tiny JavaScript mistake in this:
window.open(calEvent.url, _self);

Could you please replace _self with '_self'?

aspilicious’s picture

I updated the branch thnx pjcdawkins.
It isn't rly the issue described here, but its easier to fix everything at once ;)

tim.plunkett’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)
aspilicious’s picture

Status: Patch (to be ported) » Needs review
FileSize
2.34 KB

Build on colorbox and rtl

tim.plunkett’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

wickwood’s picture

Version: 6.x-2.x-dev » 7.x-2.0
Category: feature » support
Status: Closed (fixed) » Active

I'm glad this feature has been added, but I can't for the life of me find where I turn it on. Could someone point me in the right the direction? The feature does not appear for me on the configuration page for FullCalendar or anywhere else that I've thought to look.

Thanks in advance!
Steve

robcarr’s picture

Issue summary: View changes
FileSize
20.83 KB

@wickwood - in the view Style settings